public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Sam Asadi <asadi.samuel@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 95/95] Staging: commedi: 8253.h: style issue fixed
Date: Tue, 15 Jul 2014 10:42:55 -0700	[thread overview]
Message-ID: <20140715174255.GA5290@kroah.com> (raw)
In-Reply-To: <1405443875-15807-1-git-send-email-asadi.samuel@gmail.com>

Patch 95/95?  Really?  Where are the other 94 patches in this series?

:(

Please look at what you are doing here, does it make sense?

On Tue, Jul 15, 2014 at 08:04:35PM +0300, Sam Asadi wrote:
> a revision to the file that previously had several style issues.
> It's clean now.

What does this mean?  What did you do in this changeset?  Describe _why_
you made the change, not the result of what happened _after_ this patch
is applied.

Please step back, take a day or two to regroup, and revisit what you are
trying to do here.  You are not sending out patches correctly at all.
Please read some tutorials on how to do this properly (try
kernelnewbies.org) and then do a dry-run by sending the patches to
yourself.

After that looks correct, then consider sending them to the kernel
developers.

But again, wait, don't rush, there's no deadline here.

greg k-h

      reply	other threads:[~2014-07-15 17:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-15 17:04 [PATCH 95/95] Staging: commedi: 8253.h: style issue fixed Sam Asadi
2014-07-15 17:42 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140715174255.GA5290@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=asadi.samuel@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox