Re: [PATCH v2 6/7] tracing: change apply_subsystem_event_filter() paths to check file->system == dir

Steven Rostedt
2014-07-16T19:59:51Z

On Wed, 16 Jul 2014 21:12:48 +0200
Oleg Nesterov <oleg@redhat.com> wrote:

> On 07/16, Steven Rostedt wrote:
> >
> > On Tue, 15 Jul 2014 20:48:29 +0200
> > Oleg Nesterov <oleg@redhat.com> wrote:
> >
> > > filter_free_subsystem_preds(), filter_free_subsystem_filters() and
> > > replace_system_preds() can simply check file->system->subsystem and
> > > avoid strcmp(call->class->system).
> > >
> > > Better yet, we can pass "struct ftrace_subsystem_dir *dir" instead of
> > > event_subsystem and just check file->system == dir.
> > >
> > > Thanks to Namhyung Kim who pointed out that replace_system_preds() can
> > > be changed too.
> >
> > What? No thanks to me for suggesting the file->system == dir idea?
> >
> > /me pouts like a baby
>
> OOPS, sorry, Iactually forgot to add "as suggested by" ;)
>
> But, otoh... who cares about rostedt when it comes to tracing area?
>

As Paul McKenney would say...

;-) ;-) ;-)

-- Steve