Re: [PATCH v2 6/7] tracing: change apply_subsystem_event_filter() paths to check file->system == dir

Steven Rostedt
2014-07-16T18:32:26Z

On Tue, 15 Jul 2014 20:48:29 +0200
Oleg Nesterov <oleg@redhat.com> wrote:

> filter_free_subsystem_preds(), filter_free_subsystem_filters() and
> replace_system_preds() can simply check file->system->subsystem and
> avoid strcmp(call->class->system).
>
> Better yet, we can pass "struct ftrace_subsystem_dir *dir" instead of
> event_subsystem and just check file->system == dir.
>
> Thanks to Namhyung Kim who pointed out that replace_system_preds() can
> be changed too.

What? No thanks to me for suggesting the file->system == dir idea?

/me pouts like a baby

-- Steve

>
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>
> ---