Re: [PATCH v2 15/29] nios2: System calls handling

Ley Foon Tan
2014-07-21T11:17:47Z

On Fri, Jul 18, 2014 at 8:56 PM, James Hogan <james.hogan@imgtec.com> wrote:
> Hi,
>
> On 15/07/14 09:45, Ley Foon Tan wrote:
>> This patch adds support for system calls from userspaces. It uses the
>> asm-generic/unistd.h definitions with architecture spcific syscall. The sys_call_table
>> is just an array defined in a C file and it contains pointers to the syscall functions.
>
> I don't think you need the renameat syscall now that renameat2 exists.
>
> Can I suggest preceding your patchset with this patch:
> https://lkml.org/lkml/2014/4/23/197
> ([RFC 3/3] asm-generic: Drop renameat syscall from default list)
>
> which drops renameat from the generic list unless __ARCH_WANT_RENAMEAT
> is defined in the arch's uapi/asm/unistd.h.
Yes, we don't need renameat syscall. Will add this patch.

Thanks.

Regards
Ley Foon