Re: [PATCH v2 15/29] nios2: System calls handling

James Hogan
2014-07-18T12:56:49Z

Hi,

On 15/07/14 09:45, Ley Foon Tan wrote:
> This patch adds support for system calls from userspaces. It uses the
> asm-generic/unistd.h definitions with architecture spcific syscall. The sys_call_table
> is just an array defined in a C file and it contains pointers to the syscall functions.

I don't think you need the renameat syscall now that renameat2 exists.

Can I suggest preceding your patchset with this patch:
https://lkml.org/lkml/2014/4/23/197
([RFC 3/3] asm-generic: Drop renameat syscall from default list)

which drops renameat from the generic list unless __ARCH_WANT_RENAMEAT
is defined in the arch's uapi/asm/unistd.h.

Cheers
James