Re: [PATCH v2 21/29] nios2: Futex operations

Arnd Bergmann
2014-07-21T08:01:59Z

On Monday 21 July 2014 11:20:02 Ley Foon Tan wrote:
> On Fri, Jul 18, 2014 at 5:55 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> > On Friday 18 July 2014 11:42:34 Thomas Gleixner wrote:
> >> On Fri, 18 Jul 2014, Arnd Bergmann wrote:
> >> > On Friday 18 July 2014 14:07:42 Ley Foon Tan wrote:
> >> > > On Thu, Jul 17, 2014 at 7:07 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> >> > If this understanding is right, we can probably just merge the
> >> > m68k implementation into the asm-generic version, as that does
> >> > exactly that, and just isn't SMP safe. I'm still unsure whether
> >> > I'm missing something here though, as everything else seems to
> >> > do this in assembly, even for non-SMP machines that could use
> >> > the trivial method that m68k has.
> >>
> >> For UP relying of pagefault disable should be good enough indeed. I
> >> guess the asm for the other UP stuff results from looking at
> >> architectures or copying from architectures which did this in ASM
> >
> > Ok, thanks for the confirmation!
> >
> > Ley Foon Tan, I think the best way forward then is for you to
> > take the m68k code and copy (or move) that into asm-generic/futex.h
> > under an #ifndef CONFIG_SMP.
>
> Okay, I will copy m68k implementation to asm-generic/futex.h.
> Do you prefer this as separate patch submission or this can be part of
> nios2 patchset?

I think it's better for everybody if you include it in your nios2
patchset, once I've seen the patch and provided an Ack. You can send
it separately for review at first.

Arnd