From: Greg KH <gregkh@linuxfoundation.org>
To: Peter Senna Tschudin <peter.senna@gmail.com>
Cc: Malcolm Priestley <tvboxspy@gmail.com>,
devel@driverdev.osuosl.org, kernel-janitors@vger.kernel.org,
Forest Bond <forest@alittletooquiet.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V4 4/6] staging: vt6556: Remove typedefs
Date: Tue, 15 Jul 2014 16:53:34 -0700 [thread overview]
Message-ID: <20140715235334.GD32651@kroah.com> (raw)
In-Reply-To: <CA+MoWDobyMvP_LW+FmW+xjE5SRjx7mEDybVLc+fF5XuUweuyEA@mail.gmail.com>
On Tue, Jul 15, 2014 at 10:05:54PM +0200, Peter Senna Tschudin wrote:
> On Tue, Jul 15, 2014 at 5:06 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Mon, Jul 14, 2014 at 09:15:31PM +0200, Peter Senna Tschudin wrote:
> >> This patch removes uneeded typedefs reported by chackpatch and removes
> >> one enum. The removed enum from card.h:
> >>
> >> typedef enum _CARD_PHY_TYPE {
> >> PHY_TYPE_AUTO = 0,
> >> PHY_TYPE_11B,
> >> PHY_TYPE_11G,
> >> PHY_TYPE_11A
> >> } CARD_PHY_TYPE, *PCARD_PHY_TYPE;
> >
> > Why did you remove this?
> Unlike the other two enums this patch change, this one is not in use.
> As checkpatch complained about the typedef and it is not currently in
> use, I removed it.
Then say that, we want to know _why_ you do something, not _what_ you
do, as it's obvious from the code as to _what_ happens.
thanks,
greg k-h
next prev parent reply other threads:[~2014-07-15 23:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-14 19:15 [PATCH V4 1/6] staging: vt6556: Cleanup trivial coding style issues Peter Senna Tschudin
2014-07-14 19:15 ` [PATCH V4 2/6] staging: vt6556: Remove double parentheses Peter Senna Tschudin
2014-07-14 19:15 ` [PATCH V4 3/6] staging: vt6556: Remove uneeded return statements Peter Senna Tschudin
2014-07-14 19:15 ` [PATCH V4 4/6] staging: vt6556: Remove typedefs Peter Senna Tschudin
2014-07-15 15:06 ` Greg KH
2014-07-15 20:05 ` Peter Senna Tschudin
2014-07-15 23:53 ` Greg KH [this message]
2014-07-14 19:15 ` [PATCH V4 5/6] staging: vt6556: Cleanup indentation on statements Peter Senna Tschudin
2014-07-15 15:07 ` Greg KH
2014-07-14 19:15 ` [PATCH V4 6/6] staging: vt6556: Replace printk by pr_warn Peter Senna Tschudin
2014-07-15 15:06 ` Greg KH
2014-07-15 15:04 ` [PATCH V4 1/6] staging: vt6556: Cleanup trivial coding style issues Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140715235334.GD32651@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=forest@alittletooquiet.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.senna@gmail.com \
--cc=tvboxspy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox