* [PATCH] staging: emxx_udc: Fix coding style errors
@ 2014-07-16 1:16 Stone Kang
2014-07-16 2:21 ` Greg Kroah-Hartman
0 siblings, 1 reply; 4+ messages in thread
From: Stone Kang @ 2014-07-16 1:16 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Sachin Kamat, Magnus Damm, Simon Horman, devel, linux-kernel
Only fixing errors reported by checkpatch.pl, based on the following
rules:
1. '*' should be adjacent to the data name or function name.
2. Don't use C99-style "// ..." comments.
Signed-off-by: KANG Yuxuan <stonekyx@gmail.com>
---
drivers/staging/emxx_udc/emxx_udc.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c
index 0003463..b2eaf01 100644
--- a/drivers/staging/emxx_udc/emxx_udc.c
+++ b/drivers/staging/emxx_udc/emxx_udc.c
@@ -562,12 +562,12 @@ static void _nbu2ss_dma_unmap_single(
/*-------------------------------------------------------------------------*/
/* Endpoint 0 OUT Transfer (PIO) */
-static int EP0_out_PIO(struct nbu2ss_udc *udc, u8* pBuf, u32 length)
+static int EP0_out_PIO(struct nbu2ss_udc *udc, u8 *pBuf, u32 length)
{
u32 i;
int nret = 0;
u32 iWordLength = 0;
- USB_REG_ACCESS* pBuf32 = (USB_REG_ACCESS *)pBuf;
+ USB_REG_ACCESS *pBuf32 = (USB_REG_ACCESS *)pBuf;
/*------------------------------------------------------------*/
/* Read Length */
@@ -588,12 +588,12 @@ static int EP0_out_PIO(struct nbu2ss_udc *udc, u8* pBuf, u32 length)
/*-------------------------------------------------------------------------*/
/* Endpoint 0 OUT Transfer (PIO, OverBytes) */
-static int EP0_out_OverBytes(struct nbu2ss_udc *udc, u8* pBuf, u32 length)
+static int EP0_out_OverBytes(struct nbu2ss_udc *udc, u8 *pBuf, u32 length)
{
u32 i;
u32 iReadSize = 0;
USB_REG_ACCESS Temp32;
- USB_REG_ACCESS* pBuf32 = (USB_REG_ACCESS *)pBuf;
+ USB_REG_ACCESS *pBuf32 = (USB_REG_ACCESS *)pBuf;
if ((0 < length) && (length < sizeof(u32))) {
Temp32.dw = _nbu2ss_readl(&udc->p_regs->EP0_READ);
@@ -613,7 +613,7 @@ static int EP0_in_PIO(struct nbu2ss_udc *udc, u8 *pBuf, u32 length)
u32 iMaxLength = EP0_PACKETSIZE;
u32 iWordLength = 0;
u32 iWriteLength = 0;
- USB_REG_ACCESS* pBuf32 = (USB_REG_ACCESS *)pBuf;
+ USB_REG_ACCESS *pBuf32 = (USB_REG_ACCESS *)pBuf;
/*------------------------------------------------------------*/
/* Transfer Length */
@@ -639,7 +639,7 @@ static int EP0_in_OverBytes(struct nbu2ss_udc *udc, u8 *pBuf, u32 iRemainSize)
{
u32 i;
USB_REG_ACCESS Temp32;
- USB_REG_ACCESS* pBuf32 = (USB_REG_ACCESS *)pBuf;
+ USB_REG_ACCESS *pBuf32 = (USB_REG_ACCESS *)pBuf;
if ((0 < iRemainSize) && (iRemainSize < sizeof(u32))) {
for (i = 0 ; i < iRemainSize ; i++)
@@ -3339,7 +3339,7 @@ static int __init nbu2ss_drv_contest_init(
udc->gadget.ep0 = &udc->ep[0].ep;
udc->gadget.speed = USB_SPEED_UNKNOWN;
udc->gadget.name = driver_name;
- //udc->gadget.is_dualspeed = 1;
+ /* udc->gadget.is_dualspeed = 1; */
device_initialize(&udc->gadget.dev);
--
2.0.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: emxx_udc: Fix coding style errors
2014-07-16 1:16 [PATCH] staging: emxx_udc: Fix coding style errors Stone Kang
@ 2014-07-16 2:21 ` Greg Kroah-Hartman
2014-07-16 2:55 ` Stone Kang
0 siblings, 1 reply; 4+ messages in thread
From: Greg Kroah-Hartman @ 2014-07-16 2:21 UTC (permalink / raw)
To: Stone Kang; +Cc: devel, Simon Horman, Magnus Damm, Sachin Kamat, linux-kernel
On Wed, Jul 16, 2014 at 09:16:15AM +0800, Stone Kang wrote:
> Only fixing errors reported by checkpatch.pl, based on the following
> rules:
> 1. '*' should be adjacent to the data name or function name.
> 2. Don't use C99-style "// ..." comments.
>
> Signed-off-by: KANG Yuxuan <stonekyx@gmail.com>
I see two different names here, one in the "From:" line, and one in the
Signed-off-by: line, are they the same? They need to match up :(
Please resend with this fixed.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] staging: emxx_udc: Fix coding style errors
@ 2014-07-16 2:45 KANG Yuxuan
0 siblings, 0 replies; 4+ messages in thread
From: KANG Yuxuan @ 2014-07-16 2:45 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Sachin Kamat, Magnus Damm, Simon Horman, devel, linux-kernel
Only fixing errors reported by checkpatch.pl, based on the following
rules:
1. '*' should be adjacent to the data name or function name.
2. Don't use C99-style "// ..." comments.
Signed-off-by: KANG Yuxuan <stonekyx@gmail.com>
---
drivers/staging/emxx_udc/emxx_udc.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c
index 0003463..b2eaf01 100644
--- a/drivers/staging/emxx_udc/emxx_udc.c
+++ b/drivers/staging/emxx_udc/emxx_udc.c
@@ -562,12 +562,12 @@ static void _nbu2ss_dma_unmap_single(
/*-------------------------------------------------------------------------*/
/* Endpoint 0 OUT Transfer (PIO) */
-static int EP0_out_PIO(struct nbu2ss_udc *udc, u8* pBuf, u32 length)
+static int EP0_out_PIO(struct nbu2ss_udc *udc, u8 *pBuf, u32 length)
{
u32 i;
int nret = 0;
u32 iWordLength = 0;
- USB_REG_ACCESS* pBuf32 = (USB_REG_ACCESS *)pBuf;
+ USB_REG_ACCESS *pBuf32 = (USB_REG_ACCESS *)pBuf;
/*------------------------------------------------------------*/
/* Read Length */
@@ -588,12 +588,12 @@ static int EP0_out_PIO(struct nbu2ss_udc *udc, u8* pBuf, u32 length)
/*-------------------------------------------------------------------------*/
/* Endpoint 0 OUT Transfer (PIO, OverBytes) */
-static int EP0_out_OverBytes(struct nbu2ss_udc *udc, u8* pBuf, u32 length)
+static int EP0_out_OverBytes(struct nbu2ss_udc *udc, u8 *pBuf, u32 length)
{
u32 i;
u32 iReadSize = 0;
USB_REG_ACCESS Temp32;
- USB_REG_ACCESS* pBuf32 = (USB_REG_ACCESS *)pBuf;
+ USB_REG_ACCESS *pBuf32 = (USB_REG_ACCESS *)pBuf;
if ((0 < length) && (length < sizeof(u32))) {
Temp32.dw = _nbu2ss_readl(&udc->p_regs->EP0_READ);
@@ -613,7 +613,7 @@ static int EP0_in_PIO(struct nbu2ss_udc *udc, u8 *pBuf, u32 length)
u32 iMaxLength = EP0_PACKETSIZE;
u32 iWordLength = 0;
u32 iWriteLength = 0;
- USB_REG_ACCESS* pBuf32 = (USB_REG_ACCESS *)pBuf;
+ USB_REG_ACCESS *pBuf32 = (USB_REG_ACCESS *)pBuf;
/*------------------------------------------------------------*/
/* Transfer Length */
@@ -639,7 +639,7 @@ static int EP0_in_OverBytes(struct nbu2ss_udc *udc, u8 *pBuf, u32 iRemainSize)
{
u32 i;
USB_REG_ACCESS Temp32;
- USB_REG_ACCESS* pBuf32 = (USB_REG_ACCESS *)pBuf;
+ USB_REG_ACCESS *pBuf32 = (USB_REG_ACCESS *)pBuf;
if ((0 < iRemainSize) && (iRemainSize < sizeof(u32))) {
for (i = 0 ; i < iRemainSize ; i++)
@@ -3339,7 +3339,7 @@ static int __init nbu2ss_drv_contest_init(
udc->gadget.ep0 = &udc->ep[0].ep;
udc->gadget.speed = USB_SPEED_UNKNOWN;
udc->gadget.name = driver_name;
- //udc->gadget.is_dualspeed = 1;
+ /* udc->gadget.is_dualspeed = 1; */
device_initialize(&udc->gadget.dev);
--
2.0.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: emxx_udc: Fix coding style errors
2014-07-16 2:21 ` Greg Kroah-Hartman
@ 2014-07-16 2:55 ` Stone Kang
0 siblings, 0 replies; 4+ messages in thread
From: Stone Kang @ 2014-07-16 2:55 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: devel, Simon Horman, Magnus Damm, Sachin Kamat, linux-kernel
Hi Greg,
On Tue, Jul 15, 2014 at 07:21:28PM -0700, Greg Kroah-Hartman wrote:
> On Wed, Jul 16, 2014 at 09:16:15AM +0800, Stone Kang wrote:
> > Only fixing errors reported by checkpatch.pl, based on the following
> > rules:
> > 1. '*' should be adjacent to the data name or function name.
> > 2. Don't use C99-style "// ..." comments.
> >
> > Signed-off-by: KANG Yuxuan <stonekyx@gmail.com>
>
> I see two different names here, one in the "From:" line, and one in the
> Signed-off-by: line, are they the same? They need to match up :(
>
> Please resend with this fixed.
>
> thanks,
>
> greg k-h
Sorry, I forgot to set the From: line.
New patch has been sent, but as the content didn't change, no 'v2' tag
was attached in the title.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-07-16 2:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-16 1:16 [PATCH] staging: emxx_udc: Fix coding style errors Stone Kang
2014-07-16 2:21 ` Greg Kroah-Hartman
2014-07-16 2:55 ` Stone Kang
-- strict thread matches above, loose matches on Subject: below --
2014-07-16 2:45 KANG Yuxuan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox