From: Stone Kang <stonekyx@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org,
Simon Horman <horms+renesas@verge.net.au>,
Magnus Damm <damm+renesas@opensource.se>,
Sachin Kamat <sachin.kamat@samsung.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: emxx_udc: Fix coding style errors
Date: Wed, 16 Jul 2014 10:55:45 +0800 [thread overview]
Message-ID: <20140716025545.GA27842@stone-arch> (raw)
In-Reply-To: <20140716022128.GA22440@kroah.com>
Hi Greg,
On Tue, Jul 15, 2014 at 07:21:28PM -0700, Greg Kroah-Hartman wrote:
> On Wed, Jul 16, 2014 at 09:16:15AM +0800, Stone Kang wrote:
> > Only fixing errors reported by checkpatch.pl, based on the following
> > rules:
> > 1. '*' should be adjacent to the data name or function name.
> > 2. Don't use C99-style "// ..." comments.
> >
> > Signed-off-by: KANG Yuxuan <stonekyx@gmail.com>
>
> I see two different names here, one in the "From:" line, and one in the
> Signed-off-by: line, are they the same? They need to match up :(
>
> Please resend with this fixed.
>
> thanks,
>
> greg k-h
Sorry, I forgot to set the From: line.
New patch has been sent, but as the content didn't change, no 'v2' tag
was attached in the title.
next prev parent reply other threads:[~2014-07-16 2:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-16 1:16 [PATCH] staging: emxx_udc: Fix coding style errors Stone Kang
2014-07-16 2:21 ` Greg Kroah-Hartman
2014-07-16 2:55 ` Stone Kang [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-07-16 2:45 KANG Yuxuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140716025545.GA27842@stone-arch \
--to=stonekyx@gmail.com \
--cc=damm+renesas@opensource.se \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=horms+renesas@verge.net.au \
--cc=linux-kernel@vger.kernel.org \
--cc=sachin.kamat@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox