From: Gleb Natapov <gleb@kernel.org>
To: Andy Lutomirski <luto@amacapital.net>
Cc: kvm@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
"Theodore Ts'o" <tytso@mit.edu>,
linux-kernel@vger.kernel.org, Kees Cook <keescook@chromium.org>,
x86@kernel.org, Daniel Borkmann <dborkman@redhat.com>,
Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>,
Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>
Subject: Re: [PATCH 0/4] random,x86,kvm: Add and use MSR_KVM_GET_RNG_SEED
Date: Wed, 16 Jul 2014 09:41:11 +0300 [thread overview]
Message-ID: <20140716064110.GV18167@minantech.com> (raw)
In-Reply-To: <cover.1405477965.git.luto@amacapital.net>
On Tue, Jul 15, 2014 at 07:48:06PM -0700, Andy Lutomirski wrote:
> virtio-rng is both too complicated and insufficient for initial rng
> seeding. It's far too complicated to use for KASLR or any other
> early boot random number needs. It also provides /dev/random-style
> bits, which means that making guest boot wait for virtio-rng is
> unacceptably slow, and doing it asynchronously means that
> /dev/urandom might be predictable when userspace starts.
>
> This introduces a very simple synchronous mechanism to get
> /dev/urandom-style bits.
Why can't you use RDRAND instruction for that?
>
> This is a KVM change: am I supposed to write a unit test somewhere?
>
> Andy Lutomirski (4):
> x86,kvm: Add MSR_KVM_GET_RNG_SEED and a matching feature bit
> random,x86: Add arch_get_slow_rng_u64
> random: Seed pools from arch_get_slow_rng_u64 at startup
> x86,kaslr: Use MSR_KVM_GET_RNG_SEED for KASLR if available
>
> Documentation/virtual/kvm/cpuid.txt | 3 +++
> arch/x86/Kconfig | 4 ++++
> arch/x86/boot/compressed/aslr.c | 27 +++++++++++++++++++++++++++
> arch/x86/include/asm/archslowrng.h | 30 ++++++++++++++++++++++++++++++
> arch/x86/include/uapi/asm/kvm_para.h | 2 ++
> arch/x86/kernel/kvm.c | 22 ++++++++++++++++++++++
> arch/x86/kvm/cpuid.c | 3 ++-
> arch/x86/kvm/x86.c | 4 ++++
> drivers/char/random.c | 14 +++++++++++++-
> include/linux/random.h | 9 +++++++++
> 10 files changed, 116 insertions(+), 2 deletions(-)
> create mode 100644 arch/x86/include/asm/archslowrng.h
>
> --
> 1.9.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Gleb.
next prev parent reply other threads:[~2014-07-16 6:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-16 2:48 [PATCH 0/4] random,x86,kvm: Add and use MSR_KVM_GET_RNG_SEED Andy Lutomirski
2014-07-16 2:48 ` [PATCH 1/4] x86,kvm: Add MSR_KVM_GET_RNG_SEED and a matching feature bit Andy Lutomirski
2014-07-16 2:48 ` [PATCH 2/4] random,x86: Add arch_get_slow_rng_u64 Andy Lutomirski
2014-07-16 2:48 ` [PATCH 3/4] random: Seed pools from arch_get_slow_rng_u64 at startup Andy Lutomirski
2014-07-16 2:48 ` [PATCH 4/4] x86,kaslr: Use MSR_KVM_GET_RNG_SEED for KASLR if available Andy Lutomirski
2014-07-16 6:41 ` Gleb Natapov [this message]
2014-07-16 7:10 ` [PATCH 0/4] random,x86,kvm: Add and use MSR_KVM_GET_RNG_SEED Daniel Borkmann
2014-07-16 7:23 ` Gleb Natapov
2014-07-16 7:36 ` Paolo Bonzini
2014-07-16 14:07 ` Andy Lutomirski
2014-07-16 14:32 ` Paolo Bonzini
2014-07-16 14:53 ` Gleb Natapov
2014-07-16 15:56 ` Andy Lutomirski
2014-07-16 16:03 ` H. Peter Anvin
2014-07-16 16:08 ` Paolo Bonzini
2014-07-16 16:13 ` H. Peter Anvin
2014-07-16 16:21 ` Gleb Natapov
2014-07-16 20:20 ` H. Peter Anvin
2014-07-16 21:32 ` Andy Lutomirski
2014-07-16 21:36 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140716064110.GV18167@minantech.com \
--to=gleb@kernel.org \
--cc=dborkman@redhat.com \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=raghavendra.kt@linux.vnet.ibm.com \
--cc=tytso@mit.edu \
--cc=vatsa@linux.vnet.ibm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).