[PATCH] Staging: gdm724x: fix missing blank line after variable declaration

[PATCH] Staging: gdm724x: fix missing blank line after variable declaration

[Kiran Padwal]

From: Kiran Padwal <kiran.padwal@gmail.com>

Checkpatch fix - Add missing blank line after variable declaration

Signed-off-by:Kiran Padwal <kiran.padwal21@gmail.com>

---
 drivers/staging/gdm724x/gdm_lte.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/staging/gdm724x/gdm_lte.c b/drivers/staging/gdm724x/gdm_lte.c
index 64c55b9..bc6d574 100644
--- a/drivers/staging/gdm724x/gdm_lte.c
+++ b/drivers/staging/gdm724x/gdm_lte.c
@@ -447,6 +447,7 @@ static int gdm_lte_tx(struct sk_buff *skb, struct net_device *dev)
 	 */
 	if (nic_type & NIC_TYPE_F_VLAN) {
 		struct vlan_ethhdr *vlan_eth = (struct vlan_ethhdr *)skb->data;
+
 		nic->vlan_id = ntohs(vlan_eth->h_vlan_TCI) & VLAN_VID_MASK;
 		data_buf = skb->data + (VLAN_ETH_HLEN - ETH_HLEN);
 		data_len = skb->len - (VLAN_ETH_HLEN - ETH_HLEN);
@@ -505,6 +506,7 @@ static int gdm_lte_tx(struct sk_buff *skb, struct net_device *dev)
 static struct net_device_stats *gdm_lte_stats(struct net_device *dev)
 {
 	struct nic *nic = netdev_priv(dev);
+
 	return &nic->stats;
 }
 
-- 
1.7.9.5

[PATCH] Staging: gdm724x: fix missing blank line after variable declaration

[Kiran Padwal]

Checkpatch fix - Add missing blank line after variable declaration

Signed-off-by: Kiran Padwal <kiran.padwal21@gmail.com>
---
 drivers/staging/gdm724x/gdm_tty.c |    5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
index fe47cd3..001348c 100644
--- a/drivers/staging/gdm724x/gdm_tty.c
+++ b/drivers/staging/gdm724x/gdm_tty.c
@@ -111,24 +111,28 @@ static int gdm_tty_install(struct tty_driver *driver, struct tty_struct *tty)
 static int gdm_tty_open(struct tty_struct *tty, struct file *filp)
 {
 	struct gdm *gdm = tty->driver_data;
+
 	return tty_port_open(&gdm->port, tty, filp);
 }
 
 static void gdm_tty_cleanup(struct tty_struct *tty)
 {
 	struct gdm *gdm = tty->driver_data;
+
 	tty_port_put(&gdm->port);
 }
 
 static void gdm_tty_hangup(struct tty_struct *tty)
 {
 	struct gdm *gdm = tty->driver_data;
+
 	tty_port_hangup(&gdm->port);
 }
 
 static void gdm_tty_close(struct tty_struct *tty, struct file *filp)
 {
 	struct gdm *gdm = tty->driver_data;
+
 	tty_port_close(&gdm->port, tty, filp);
 }
 
@@ -139,6 +143,7 @@ static int gdm_tty_recv_complete(void *data,
 				 int complete)
 {
 	struct gdm *gdm = tty_dev->gdm[index];
+
 	if (!GDM_TTY_READY(gdm)) {
 		if (complete == RECV_PACKET_PROCESS_COMPLETE)
 			gdm_tty_recv(gdm, gdm_tty_recv_complete);
-- 
1.7.9.5

Re: [PATCH] Staging: gdm724x: fix missing blank line after variable declaration

[Greg KH]

On Wed, Jul 16, 2014 at 04:55:23PM +0530, Kiran Padwal wrote:
> From: Kiran Padwal <kiran.padwal@gmail.com>
> 
> Checkpatch fix - Add missing blank line after variable declaration
> 
> Signed-off-by:Kiran Padwal <kiran.padwal21@gmail.com>

Minor nit, you need a ' ' after the ':'.

Also, you sent me two different patches, with the same Subject: line.
So I can't apply either of them, sorry.  Please resend both of them with
better subject lines (hint, put the filename in the subject: that would
fix this...)

thanks,

greg k-h

Re: [PATCH] Staging: gdm724x: fix missing blank line after variable declaration

[kiran padwal]

Hi,

On Thu, Jul 17, 2014 at 2:00 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Wed, Jul 16, 2014 at 04:55:23PM +0530, Kiran Padwal wrote:
>> From: Kiran Padwal <kiran.padwal@gmail.com>
>>
>> Checkpatch fix - Add missing blank line after variable declaration
>>
>> Signed-off-by:Kiran Padwal <kiran.padwal21@gmail.com>
>
> Minor nit, you need a ' ' after the ':'.
>
> Also, you sent me two different patches, with the same Subject: line.
> So I can't apply either of them, sorry.  Please resend both of them with
> better subject lines (hint, put the filename in the subject: that would
> fix this...)

Thanks, I will resend it.

>
> thanks,
>
> greg k-h