From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Allen Yu <alleny@nvidia.com>, Pavel Machek <pavel@ucw.cz>,
Len Brown <len.brown@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Linux-pm mailing list <linux-pm@vger.kernel.org>,
Kernel development list <linux-kernel@vger.kernel.org>
Subject: Re: [RFC] Add "rpm_not_supported" flag
Date: Wed, 16 Jul 2014 16:03:45 -0700 [thread overview]
Message-ID: <20140716230345.GA3220@kroah.com> (raw)
In-Reply-To: <1908592.0t6juNfLFj@vostro.rjw.lan>
On Thu, Jul 17, 2014 at 12:40:23AM +0200, Rafael J. Wysocki wrote:
> On Wednesday, July 02, 2014 10:27:06 AM Alan Stern wrote:
> > Here's a brief summary of the story behind this patch...
> >
> > At one point, I suggested to Dan that instead of doing something
> > special for these devices, we could simply have the runtime_suspend()
> > routine always return -EBUSY. He didn't like that idea because then
> > the user would see the device was never powering down but would have no
> > idea why. The rpm_not_supported flag provides this information to the
> > user by causing the power/runtime_status attribute to say "not
> > supported". (Although to be entirely fair, we could just put a message
> > in the kernel log during probe if the hardware doesn't support runtime
> > suspend.)
> >
> > Instead, Dan introduced a messy PM QoS mechanism in commit
> > e3d105055525. I didn't like that approach, but Greg merged it before I
> > objected.
>
> That really looks a bit like a hack to me to be honest.
>
> Greg, what's your plan toward this?
If I need to revert something that you all find was wrong, I'll be glad
to do so, sorry for merging something too early.
thanks,
greg k-h
next prev parent reply other threads:[~2014-07-16 23:03 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-14 10:03 [PATCH 1/1] PM / Runtime: let rpm_resume fail if rpm disabled and device suspended Allen Yu
2014-06-14 14:32 ` Alan Stern
2014-06-16 3:03 ` Allen Yu
2014-06-16 14:43 ` Alan Stern
2014-06-16 17:40 ` Alan Stern
2014-06-16 21:29 ` Rafael J. Wysocki
2014-06-17 14:11 ` Alan Stern
2014-06-17 20:26 ` Rafael J. Wysocki
2014-06-17 20:37 ` Rafael J. Wysocki
2014-06-17 20:46 ` Rafael J. Wysocki
2014-06-18 15:30 ` Alan Stern
2014-06-18 23:57 ` Rafael J. Wysocki
2014-06-19 8:23 ` Allen Yu
2014-06-19 13:55 ` Rafael J. Wysocki
2014-06-19 14:34 ` Allen Yu
2014-06-20 14:04 ` Rafael J. Wysocki
2014-06-19 14:56 ` Alan Stern
2014-06-19 19:25 ` Kevin Hilman
2014-06-19 20:13 ` Alan Stern
2014-06-20 13:20 ` Rafael J. Wysocki
2014-06-20 14:48 ` Alan Stern
2014-06-20 21:34 ` Kevin Hilman
2014-06-22 13:40 ` Rafael J. Wysocki
2014-06-22 13:24 ` Rafael J. Wysocki
2014-06-20 21:31 ` Kevin Hilman
2014-06-21 13:34 ` Alan Stern
2014-06-22 13:35 ` Rafael J. Wysocki
2014-06-23 18:57 ` Kevin Hilman
2014-06-19 14:34 ` Alan Stern
2014-06-20 13:33 ` Rafael J. Wysocki
2014-06-20 14:43 ` Alan Stern
2014-06-22 13:21 ` Rafael J. Wysocki
2014-06-22 16:45 ` Alan Stern
2014-06-24 23:38 ` Rafael J. Wysocki
2014-06-27 18:27 ` [RFC] Add "rpm_not_supported" flag Alan Stern
2014-06-27 19:22 ` Greg Kroah-Hartman
2014-06-27 20:11 ` Alan Stern
2014-06-27 20:50 ` Greg Kroah-Hartman
2014-06-28 15:32 ` Alan Stern
2014-06-30 13:52 ` Rafael J. Wysocki
2014-06-30 14:42 ` Alan Stern
2014-07-01 23:18 ` Rafael J. Wysocki
2014-07-02 14:27 ` Alan Stern
2014-07-02 17:56 ` Greg Kroah-Hartman
2014-07-03 21:16 ` Rafael J. Wysocki
2014-07-03 21:17 ` Alan Stern
2014-07-16 22:40 ` Rafael J. Wysocki
2014-07-16 23:03 ` Greg Kroah-Hartman [this message]
2014-07-16 23:27 ` Rafael J. Wysocki
2014-07-17 14:27 ` Alan Stern
2014-07-18 0:48 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140716230345.GA3220@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alleny@nvidia.com \
--cc=dan.j.williams@intel.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox