From: Josh Triplett <josh@joshtriplett.org>
To: Pranith Kumar <bobby.prani@gmail.com>
Cc: Lai Jiangshan <laijs@cn.fujitsu.com>,
paulmck@linux.vnet.ibm.com, Steven Rostedt <rostedt@goodmis.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
"open list:READ-COPY UPDATE..." <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] rcu: Remove stale comment in tree.c
Date: Wed, 16 Jul 2014 19:14:06 -0700 [thread overview]
Message-ID: <20140717021405.GA1102@thin> (raw)
In-Reply-To: <53C72080.5040501@gmail.com>
On Wed, Jul 16, 2014 at 09:01:52PM -0400, Pranith Kumar wrote:
> Sure, please find an updated patch with Josh Triplett's sign-off added:
It appears to have a reviewed-by from someone named "Joe Tripplett"
instead. ;)
> From: Pranith Kumar <bobby.prani@gmail.com>
> Date: Mon, 14 Jul 2014 16:01:05 -0400
> Subject: [PATCH 2/3] rcu: Remove stale comment in tree.c
>
>
> This commit removes a stale comment in rcu/tree.c which was left out in
> commit 2036d94a7b61ca5032ce (rcu: Rework detection of use of RCU by offline CPUs)
>
> For reference, the following updated comment exists a few lines below this which
> means the same.
>
> /* Remove the outgoing CPU from the masks in the rcu_node hierarchy. */
>
> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
> Reviewed-by: Joe Tripplett <josh@joshtriplett.org>
> ---
> kernel/rcu/tree.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
> index a1abaa8..e67246e 100644
> --- a/kernel/rcu/tree.c
> +++ b/kernel/rcu/tree.c
> @@ -2211,8 +2211,6 @@ static void rcu_cleanup_dead_cpu(int cpu, struct rcu_state *rsp)
> /* Adjust any no-longer-needed kthreads. */
> rcu_boost_kthread_setaffinity(rnp, -1);
>
> - /* Remove the dead CPU from the bitmasks in the rcu_node hierarchy. */
> -
> /* Exclude any attempts to start a new grace period. */
> mutex_lock(&rsp->onoff_mutex);
> raw_spin_lock_irqsave(&rsp->orphan_lock, flags);
> --
> 1.9.1
>
next prev parent reply other threads:[~2014-07-17 2:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-15 22:31 [PATCH 1/3] rcu: tiny.c: Update reference to tree.c Pranith Kumar
2014-07-15 22:31 ` [PATCH 2/3] rcu: Remove stale comment in tree.c Pranith Kumar
2014-07-15 22:53 ` josh
2014-07-15 22:57 ` Pranith Kumar
2014-07-16 12:47 ` Paul E. McKenney
2014-07-16 13:29 ` Pranith Kumar
2014-07-16 23:32 ` josh
2014-07-17 0:55 ` Lai Jiangshan
2014-07-17 1:01 ` Pranith Kumar
2014-07-17 1:25 ` Lai Jiangshan
2014-07-17 1:26 ` Pranith Kumar
2014-07-17 2:14 ` Josh Triplett [this message]
2014-07-17 2:20 ` Pranith Kumar
2014-07-17 23:33 ` Paul E. McKenney
2014-07-15 22:31 ` [PATCH 3/3] rcu: Use rcu_num_nodes instead of NUM_RCU_NODES Pranith Kumar
2014-07-15 22:54 ` josh
2014-07-16 12:45 ` Paul E. McKenney
2014-07-16 13:26 ` Pranith Kumar
2014-07-15 22:52 ` [PATCH 1/3] rcu: tiny.c: Update reference to tree.c josh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140717021405.GA1102@thin \
--to=josh@joshtriplett.org \
--cc=bobby.prani@gmail.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).