* [PATCH v2] staging: android: Fixed missing blank line
@ 2014-07-17 9:13 sanjeev sharma
2014-07-17 9:10 ` Dan Carpenter
0 siblings, 1 reply; 4+ messages in thread
From: sanjeev sharma @ 2014-07-17 9:13 UTC (permalink / raw)
To: gregkh
Cc: daniel, waydi1, devel, linux-kernel, swetland, sanjeevs1,
Sanjeev Sharma
From: sanjeevs1 <sanjeev_sharma@mentor.com>
This patch will add an blank line after
declaration reported by checkpatch.pl script.
Signed-off-by: Sanjeev Sharma <Sanjeev_Sharma@mentor.com>
---
Changes in v2:
- Fixed frm header
drivers/staging/android/sw_sync.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/android/sw_sync.c b/drivers/staging/android/sw_sync.c
index a76db3f..863d4b1 100644
--- a/drivers/staging/android/sw_sync.c
+++ b/drivers/staging/android/sw_sync.c
@@ -97,6 +97,7 @@ static void sw_sync_pt_value_str(struct sync_pt *sync_pt,
char *str, int size)
{
struct sw_sync_pt *pt = (struct sw_sync_pt *)sync_pt;
+
snprintf(str, size, "%d", pt->value);
}
@@ -156,6 +157,7 @@ static int sw_sync_open(struct inode *inode, struct file *file)
static int sw_sync_release(struct inode *inode, struct file *file)
{
struct sw_sync_timeline *obj = file->private_data;
+
sync_timeline_destroy(&obj->obj);
return 0;
}
--
1.7.11.7
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] staging: android: Fixed missing blank line
2014-07-17 9:13 [PATCH v2] staging: android: Fixed missing blank line sanjeev sharma
@ 2014-07-17 9:10 ` Dan Carpenter
2014-07-18 4:36 ` Sharma, Sanjeev
0 siblings, 1 reply; 4+ messages in thread
From: Dan Carpenter @ 2014-07-17 9:10 UTC (permalink / raw)
To: sanjeev sharma; +Cc: gregkh, devel, waydi1, swetland, linux-kernel, daniel
On Thu, Jul 17, 2014 at 02:43:27PM +0530, sanjeev sharma wrote:
> From: sanjeevs1 <sanjeev_sharma@mentor.com>
Only use this if you are sending on behalf of someone else.
>
> This patch will add an blank line after
> declaration reported by checkpatch.pl script.
>
> Signed-off-by: Sanjeev Sharma <Sanjeev_Sharma@mentor.com>
> ---
> Changes in v2:
> - Fixed frm header
Send these to yourself to test.
Also look at your email.
Bad - From: sanjeev sharma <sanjeev_sharma@mentor.com>
Good - From: Sanjeev Sharma <sanjeev_sharma@mentor.com>
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH v2] staging: android: Fixed missing blank line
2014-07-17 9:10 ` Dan Carpenter
@ 2014-07-18 4:36 ` Sharma, Sanjeev
2014-07-18 4:54 ` Dan Carpenter
0 siblings, 1 reply; 4+ messages in thread
From: Sharma, Sanjeev @ 2014-07-18 4:36 UTC (permalink / raw)
To: Dan Carpenter
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
waydi1@gmail.com, swetland@google.com,
linux-kernel@vger.kernel.org, daniel@ffwll.ch
Done ! ,Please review now.
Regards
Sanjeev Sharma
-----Original Message-----
From: Dan Carpenter [mailto:dan.carpenter@oracle.com]
Sent: Thursday, July 17, 2014 2:41 PM
To: Sharma, Sanjeev
Cc: gregkh@linuxfoundation.org; devel@driverdev.osuosl.org; waydi1@gmail.com; swetland@google.com; linux-kernel@vger.kernel.org; daniel@ffwll.ch
Subject: Re: [PATCH v2] staging: android: Fixed missing blank line
On Thu, Jul 17, 2014 at 02:43:27PM +0530, sanjeev sharma wrote:
> From: sanjeevs1 <sanjeev_sharma@mentor.com>
Only use this if you are sending on behalf of someone else.
>
> This patch will add an blank line after declaration reported by
> checkpatch.pl script.
>
> Signed-off-by: Sanjeev Sharma <Sanjeev_Sharma@mentor.com>
> ---
> Changes in v2:
> - Fixed frm header
Send these to yourself to test.
Also look at your email.
Bad - From: sanjeev sharma <sanjeev_sharma@mentor.com> Good - From: Sanjeev Sharma <sanjeev_sharma@mentor.com>
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] staging: android: Fixed missing blank line
2014-07-18 4:36 ` Sharma, Sanjeev
@ 2014-07-18 4:54 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2014-07-18 4:54 UTC (permalink / raw)
To: Sharma, Sanjeev
Cc: devel@driverdev.osuosl.org, waydi1@gmail.com,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
daniel@ffwll.ch, swetland@google.com
On Fri, Jul 18, 2014 at 04:36:42AM +0000, Sharma, Sanjeev wrote:
> Done ! ,Please review now.
>
Looks ok.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-07-18 4:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-17 9:13 [PATCH v2] staging: android: Fixed missing blank line sanjeev sharma
2014-07-17 9:10 ` Dan Carpenter
2014-07-18 4:36 ` Sharma, Sanjeev
2014-07-18 4:54 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox