From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755757AbaGQJpd (ORCPT ); Thu, 17 Jul 2014 05:45:33 -0400 Received: from mail.skyhub.de ([78.46.96.112]:46169 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755311AbaGQJp3 (ORCPT ); Thu, 17 Jul 2014 05:45:29 -0400 Date: Thu, 17 Jul 2014 11:44:13 +0200 From: Borislav Petkov To: Peter Feuerer Cc: LKML , Andrew Morton , Andreas Mohr , Borislav Petkov Subject: Re: [PATCH v3 1/6] acerhdf: Adding support for "manual mode" Message-ID: <20140717094413.GA23869@pd.tnic> References: <1398561815-22033-1-git-send-email-peter@piie.net> <1399139966-10625-1-git-send-email-peter@piie.net> <1399139966-10625-2-git-send-email-peter@piie.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1399139966-10625-2-git-send-email-peter@piie.net> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 03, 2014 at 07:59:21PM +0200, Peter Feuerer wrote: > Some Acer models require an additional command to turn off the fan after > bios mode has been enabled. Adding new section in bios table to allow > support for those models, by writing an extra "manual mode" register. > > Cc: Andrew Morton > Cc: Andreas Mohr > Cc: Borislav Petkov > Signed-off-by: Peter Feuerer Looks ok, I guess. I do worry a bit about the growing size of this bios_tbl and how it contains lotsa repeated info - you might wanna think of a slick scheme to slim it down one day, if you're bored. Acked-by: Borislav Petkov -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. --