Re: [PATCH v3 1/6] acerhdf: Adding support for "manual mode"

Borislav Petkov
2014-07-17T09:45:33Z

On Sat, May 03, 2014 at 07:59:21PM +0200, Peter Feuerer wrote:
> Some Acer models require an additional command to turn off the fan after
> bios mode has been enabled. Adding new section in bios table to allow
> support for those models, by writing an extra "manual mode" register.
>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Andreas Mohr <andi@lisas.de>
> Cc: Borislav Petkov <bp@suse.de>
> Signed-off-by: Peter Feuerer <peter@piie.net>

Looks ok, I guess. I do worry a bit about the growing size of this
bios_tbl and how it contains lotsa repeated info - you might wanna think
of a slick scheme to slim it down one day, if you're bored.

Acked-by: Borislav Petkov <bp@suse.de>

--
Regards/Gruss,
Boris.

Sent from a fat crate under my desk. Formatting is fine.
--