From: "Petr Mládek" <pmladek@suse.cz>
To: Alex Elder <elder@linaro.org>
Cc: akpm@linux-foundation.org, bp@suse.de, john.stultz@linaro.org,
jack@suse.cz, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] printk: correct some more typos
Date: Thu, 17 Jul 2014 13:46:18 +0200 [thread overview]
Message-ID: <20140717114618.GS6774@pathway.suse.cz> (raw)
In-Reply-To: <1405531620-9983-5-git-send-email-elder@linaro.org>
On Wed 2014-07-16 12:27:00, Alex Elder wrote:
> This patch corrects a few more typographical errors in "printk.c".
>
> Signed-off-by: Alex Elder <elder@linaro.org>
> ---
> kernel/printk/printk.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
> index 3f15d95..0cbd060 100644
> --- a/kernel/printk/printk.c
> +++ b/kernel/printk/printk.c
> @@ -201,7 +201,7 @@ static int console_may_schedule;
> *
> * The optional key/value pairs are attached as continuation lines starting
> * with a space character and terminated by a newline. All possible
> - * non-prinatable characters are escaped in the "\xff" notation.
> + * non-printable characters are escaped in the "\xff" notation.
> *
> * Users of the export format should ignore possible additional values
> * separated by ',', and find the message after the ';' character.
> @@ -411,7 +411,7 @@ static int log_store(int facility, int level,
> /* truncate the message if it is too long for empty buffer */
> size = truncate_msg(&text_len, &trunc_msg_len,
> &dict_len, &pad_len);
> - /* survive when the log buffer is too small for trunc_msg */
> + /* survive when the log buffer is too small for truncate_msg */
It meant the trunc_msg = "<truncated>" string. So, the original text
was more precise. I agree that it is a bit confusing :-)
The other changes look correct.
Best Regards,
Petr
> if (log_make_free_space(size))
> return 0;
> }
> @@ -614,7 +614,7 @@ static ssize_t devkmsg_read(struct file *file, char __user *buf,
> /*
> * If we couldn't merge continuation line fragments during the print,
> * export the stored flags to allow an optional external merge of the
> - * records. Merging the records isn't always neccessarily correct, like
> + * records. Merging the records isn't always necessarily correct, like
> * when we hit a race during printing. In most cases though, it produces
> * better readable output. 'c' in the record flags mark the first
> * fragment of a line, '+' the following.
> @@ -2881,7 +2881,7 @@ bool kmsg_dump_get_buffer(struct kmsg_dumper *dumper, bool syslog,
> prev = msg->flags;
> }
>
> - /* last message in next interation */
> + /* last message in next iteration */
> next_seq = seq;
> next_idx = idx;
>
> @@ -2907,7 +2907,7 @@ out:
> EXPORT_SYMBOL_GPL(kmsg_dump_get_buffer);
>
> /**
> - * kmsg_dump_rewind_nolock - reset the interator (unlocked version)
> + * kmsg_dump_rewind_nolock - reset the iterator (unlocked version)
> * @dumper: registered kmsg dumper
> *
> * Reset the dumper's iterator so that kmsg_dump_get_line() and
> @@ -2925,7 +2925,7 @@ void kmsg_dump_rewind_nolock(struct kmsg_dumper *dumper)
> }
>
> /**
> - * kmsg_dump_rewind - reset the interator
> + * kmsg_dump_rewind - reset the iterator
> * @dumper: registered kmsg dumper
> *
> * Reset the dumper's iterator so that kmsg_dump_get_line() and
> --
> 1.9.1
>
next prev parent reply other threads:[~2014-07-17 11:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-16 17:26 [PATCH 0/4] printk: start simplifying some flags Alex Elder
2014-07-16 17:26 ` [PATCH 1/4] printk: LOG_CONT and LOG_NEWLINE are separate Alex Elder
2014-07-17 8:39 ` Petr Mládek
2014-07-17 12:11 ` Alex Elder
2014-07-17 14:46 ` Petr Mládek
2014-07-17 16:19 ` Alex Elder
2014-07-18 8:49 ` Petr Mládek
2014-07-17 12:31 ` Alex Elder
2014-07-16 17:26 ` [PATCH 2/4] printk: honor LOG_PREFIX in devkmsg_read() Alex Elder
2014-07-17 10:14 ` Petr Mládek
2014-07-17 12:19 ` Alex Elder
2014-07-16 17:26 ` [PATCH 3/4] printk: honor LOG_PREFIX in msg_print_text() Alex Elder
2014-07-17 9:40 ` Petr Mládek
2014-07-17 12:18 ` Alex Elder
2014-07-17 13:42 ` Alex Elder
2014-07-16 17:27 ` [PATCH 4/4] printk: correct some more typos Alex Elder
2014-07-17 11:46 ` Petr Mládek [this message]
2014-07-17 12:22 ` Alex Elder
2014-07-16 17:55 ` [PATCH 0/4] printk: start simplifying some flags Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140717114618.GS6774@pathway.suse.cz \
--to=pmladek@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=bp@suse.de \
--cc=elder@linaro.org \
--cc=jack@suse.cz \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox