From: Tejun Heo <tj@kernel.org>
To: Andrey Utkin <andrey.krieger.utkin@gmail.com>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
dcb314@hotmail.com
Subject: Re: [PATCH 1/3] drivers/ata/pata_ep93xx.c: use signed int type for result of platform_get_irq()
Date: Thu, 17 Jul 2014 08:36:47 -0400 [thread overview]
Message-ID: <20140717123647.GA21390@htj.dyndns.org> (raw)
In-Reply-To: <1405599203-11113-1-git-send-email-andrey.krieger.utkin@gmail.com>
On Thu, Jul 17, 2014 at 03:13:23PM +0300, Andrey Utkin wrote:
> [linux-3.16-rc5/drivers/ata/pata_ep93xx.c:929]: (style) Checking if unsigned
> variable 'irq' is less than zero.
>
> Source code is
>
> irq = platform_get_irq(pdev, 0);
> if (irq < 0) {
>
> but
>
> unsigned int irq;
>
> $ fgrep platform_get_irq `find . -name \*.h -print`
> ./include/linux/platform_device.h:extern int platform_get_irq(struct
> platform_device *, unsigned int);
>
> Now using "int" type instead of "unsigned int" for "irq" variable.
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=80401
> Reported-by: David Binderman <dcb314@hotmail.com>
> Signed-off-by: Andrey Utkin <andrey.krieger.utkin@gmail.com>
Applied to libata/for-3.16-fixes.
Thanks.
--
tejun
prev parent reply other threads:[~2014-07-17 12:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-17 12:13 [PATCH 1/3] drivers/ata/pata_ep93xx.c: use signed int type for result of platform_get_irq() Andrey Utkin
2014-07-17 12:36 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140717123647.GA21390@htj.dyndns.org \
--to=tj@kernel.org \
--cc=andrey.krieger.utkin@gmail.com \
--cc=dcb314@hotmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox