From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Oleg Nesterov <oleg@redhat.com>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Subject: [for-next][PATCH 4/7] tracing/uprobes: Kill the dead TRACE_EVENT_FL_USE_CALL_FILTER logic
Date: Thu, 17 Jul 2014 10:47:11 -0400 [thread overview]
Message-ID: <20140717144752.691961602@goodmis.org> (raw)
In-Reply-To: 20140717144707.625978566@goodmis.org
[-- Attachment #1: 0004-tracing-uprobes-Kill-the-dead-TRACE_EVENT_FL_USE_CAL.patch --]
[-- Type: text/plain, Size: 1352 bytes --]
From: Oleg Nesterov <oleg@redhat.com>
alloc_trace_uprobe() sets TRACE_EVENT_FL_USE_CALL_FILTER for unknown
reason and this is simply wrong. Fortunately this has no effect because
register_uprobe_event() clears call->flags after that.
Kill both. This trace_uprobe was kzalloc'ed and we rely on this fact
anyway.
Link: http://lkml.kernel.org/p/20140715184824.GA20505@redhat.com
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
kernel/trace/trace_uprobe.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
index 3c9b97e6b1f4..33ff6a24b802 100644
--- a/kernel/trace/trace_uprobe.c
+++ b/kernel/trace/trace_uprobe.c
@@ -265,7 +265,6 @@ alloc_trace_uprobe(const char *group, const char *event, int nargs, bool is_ret)
if (is_ret)
tu->consumer.ret_handler = uretprobe_dispatcher;
init_trace_uprobe_filter(&tu->filter);
- tu->tp.call.flags |= TRACE_EVENT_FL_USE_CALL_FILTER;
return tu;
error:
@@ -1292,7 +1291,7 @@ static int register_uprobe_event(struct trace_uprobe *tu)
kfree(call->print_fmt);
return -ENODEV;
}
- call->flags = 0;
+
call->class->reg = trace_uprobe_register;
call->data = tu;
ret = trace_add_event_call(call);
--
2.0.1
next prev parent reply other threads:[~2014-07-17 14:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-17 14:47 [for-next][PATCH 0/7] tracing: ->filter cleanups Steven Rostedt
2014-07-17 14:47 ` [for-next][PATCH 1/7] tracing: Kill destroy_preds() and destroy_file_preds() Steven Rostedt
2014-07-17 14:47 ` [for-next][PATCH 2/7] tracing: Kill destroy_call_preds() Steven Rostedt
2014-07-17 14:47 ` [for-next][PATCH 3/7] tracing: Kill call_filter_disable() Steven Rostedt
2014-07-17 14:47 ` Steven Rostedt [this message]
2014-07-17 14:47 ` [for-next][PATCH 5/7] tracing: Kill ftrace_event_call->files Steven Rostedt
2014-07-17 14:47 ` [for-next][PATCH 6/7] tracing: Change apply_subsystem_event_filter() paths to check file->system == dir Steven Rostedt
2014-07-17 14:47 ` [for-next][PATCH 7/7] tracing: Kill "filter_string" arg of replace_preds() Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140717144752.691961602@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox