From: Greg KH <gregkh@linuxfoundation.org>
To: Kiran Padwal <kiran.padwal21@gmail.com>
Cc: devel@driverdev.osuosl.org, gulsah.1004@gmail.com,
wkang77@gmail.com, rusty@rustcorp.com.au,
valentina.manea.m@gmail.com, linux-kernel@vger.kernel.org,
rashika.kheria@gmail.com
Subject: Re: [PATCH] Staging: gdm724x: gdm_lte.c: fix missing blank line after variable declaration
Date: Thu, 17 Jul 2014 18:05:36 -0700 [thread overview]
Message-ID: <20140718010536.GA28618@kroah.com> (raw)
In-Reply-To: <1405569638-9435-1-git-send-email-kiran.padwal21@gmail.com>
On Thu, Jul 17, 2014 at 09:30:38AM +0530, Kiran Padwal wrote:
> Checkpatch fix - Add missing blank line after variable declaration
>
> Signed-off-by: Kiran Padwal <kiran.padwal21@gmail.com>
> ---
> drivers/staging/gdm724x/gdm_lte.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/staging/gdm724x/gdm_lte.c b/drivers/staging/gdm724x/gdm_lte.c
> index 64c55b9..bc6d574 100644
> --- a/drivers/staging/gdm724x/gdm_lte.c
> +++ b/drivers/staging/gdm724x/gdm_lte.c
> @@ -447,6 +447,7 @@ static int gdm_lte_tx(struct sk_buff *skb, struct net_device *dev)
> */
> if (nic_type & NIC_TYPE_F_VLAN) {
> struct vlan_ethhdr *vlan_eth = (struct vlan_ethhdr *)skb->data;
> +
> nic->vlan_id = ntohs(vlan_eth->h_vlan_TCI) & VLAN_VID_MASK;
> data_buf = skb->data + (VLAN_ETH_HLEN - ETH_HLEN);
> data_len = skb->len - (VLAN_ETH_HLEN - ETH_HLEN);
> @@ -505,6 +506,7 @@ static int gdm_lte_tx(struct sk_buff *skb, struct net_device *dev)
> static struct net_device_stats *gdm_lte_stats(struct net_device *dev)
> {
> struct nic *nic = netdev_priv(dev);
> +
> return &nic->stats;
> }
>
Someone else sent me this same patch back in May, and it's in my tree.
Please always work against linux-next, or my staging-next branch of my
staging.git tree if you want to send me patches like this.
thanks,
greg k-h
prev parent reply other threads:[~2014-07-18 1:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-17 4:00 [PATCH] Staging: gdm724x: gdm_lte.c: fix missing blank line after variable declaration Kiran Padwal
2014-07-18 1:05 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140718010536.GA28618@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=gulsah.1004@gmail.com \
--cc=kiran.padwal21@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rashika.kheria@gmail.com \
--cc=rusty@rustcorp.com.au \
--cc=valentina.manea.m@gmail.com \
--cc=wkang77@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox