public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@suse.de>
To: Joe Perches <joe@perches.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
	Richard Weinberger <richard@nod.at>,
	akpm@linux-foundation.org, apw@canonical.com, tytso@mit.edu,
	dwalter@google.com, neilb@suse.de, hch@infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch.pl: Remove --file option
Date: Fri, 18 Jul 2014 16:49:20 +0200	[thread overview]
Message-ID: <20140718144920.GE31270@pd.tnic> (raw)
In-Reply-To: <1405694126.14358.30.camel@joe-AO725>

On Fri, Jul 18, 2014 at 07:35:26AM -0700, Joe Perches wrote:
> Using the one-liner above also makes it harder to
> automate checkpatch neatening and avoid using Lindent:

automated checkpatch?? More idiocy... we want less, in case you've
forgotten.

<snip more pointless justification attempts>

Let me state it again:

The thing is called checkpatch and not lindent or checkfile or whatever.
It is supposed to check *patches* and *not* whole files.

If people still want to check whole files, they can do so. But patches
generated from checking whole files are completely ignored by most
maintainers and don't help anyone - not the person who wants to learn to
contribute properly to the kernel and not the maintainer on the other
end who cringes at the gazillion lines patch staring him in the face.

It is about time people understood that and dropped the senseless frenzy
of creating patches with less time spent on thinking about them than
preparing them.

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--

  reply	other threads:[~2014-07-18 14:49 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-17 15:34 [PATCH] checkpatch.pl: Remove --file option Richard Weinberger
2014-07-17 15:38 ` Borislav Petkov
2014-07-17 15:51 ` Joe Perches
2014-07-17 16:02   ` Borislav Petkov
2014-07-17 16:24     ` Joe Perches
2014-07-22  5:27     ` Kalle Valo
2014-08-04 14:30       ` Pavel Machek
2014-07-17 22:43   ` Thomas Gleixner
2014-07-18  7:29 ` Guenter Roeck
2014-07-18  8:23   ` Borislav Petkov
2014-07-18 13:37     ` Guenter Roeck
2014-07-18 13:46       ` Richard Weinberger
2014-07-18 13:56         ` Guenter Roeck
2014-07-18 14:22           ` Borislav Petkov
2014-07-18 14:21         ` Christoph Hellwig
2014-07-18 14:27           ` Borislav Petkov
2014-07-18 14:43             ` Guenter Roeck
2014-07-18 14:56               ` Borislav Petkov
2014-07-18 14:17 ` Lars-Peter Clausen
2014-07-18 14:24   ` Borislav Petkov
2014-07-18 14:35     ` Joe Perches
2014-07-18 14:49       ` Borislav Petkov [this message]
2014-07-18 14:57         ` Joe Perches
2014-07-18 15:06           ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140718144920.GE31270@pd.tnic \
    --to=bp@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=apw@canonical.com \
    --cc=dwalter@google.com \
    --cc=hch@infradead.org \
    --cc=joe@perches.com \
    --cc=lars@metafoo.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=richard@nod.at \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox