From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422901AbaGRSUt (ORCPT ); Fri, 18 Jul 2014 14:20:49 -0400 Received: from asavdk4.altibox.net ([109.247.116.15]:57718 "EHLO asavdk4.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030567AbaGRSUr (ORCPT ); Fri, 18 Jul 2014 14:20:47 -0400 Date: Fri, 18 Jul 2014 20:20:29 +0200 From: Sam Ravnborg To: Nick Krause Cc: Steven Rostedt , David Miller , sparclinux@vger.kernel.org, "linux-kernel@vger.kernel.org" Subject: Re: Sparc: Fix Mes in highmem.c Message-ID: <20140718182028.GA21570@ravnborg.org> References: <20140717075204.GA15569@ravnborg.org> <20140718140812.GB23985@home.goodmis.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 18, 2014 at 01:06:41PM -0400, Nick Krause wrote: > On Fri, Jul 18, 2014 at 10:08 AM, Steven Rostedt wrote: > > On Thu, Jul 17, 2014 at 11:05:12PM -0400, Nick Krause wrote: > >> On Thu, Jul 17, 2014 at 1:38 PM, Nick Krause wrote: > >> > On Thu, Jul 17, 2014 at 3:52 AM, Sam Ravnborg wrote: > >> >> On Wed, Jul 16, 2014 at 10:25:30PM -0400, Nick Krause wrote: > >> >>> I am hitting three Fix mes in this file and am wondering as the > >> >>> maintainer how you would like > >> >>> to clean them up. > >> >> > >> >> They may be addressed if we one day decide to give the sparc32 highmem > >> >> support a big overhaul. Until then they are left as is. > >> >> > >> >> Sam > >> > Very well then I will just not touch it until we are going to > >> > overhaul the highmem for > >> > sparc32. > >> > Cheers Nick > >> If you want I can fix the sparc32 highmem area with your help. I am new > >> to the kernel so a little help if needed would be great when doing this work > >> for you:). > > > > It will take a bit more than a "little help" to do such a task. Among other > > things, owning a sparc32 box is one of them. Do you happen to have one? > > Or do you have access to one? > > > > -- Steve > > > > I understand that I don't have a sparc32 box , however if someone can > test my fixes for me this > may work. No it will not work. This is as many other areas something that require some knowledge plus some trial-and-error to do. You should understand that things takes time to learn before you can go hacking around in stuff. And highmem support in sparc32 is one such area. Time are in some areas counted in months and in other areas counted in years. This is not some simple userspace program - please try to understand this. Sam