Re: [PATCH] staging: input: sunkbd.c: Fix coding style

Dmitry Torokhov
2014-07-20T20:19:34Z

On Sun, Jul 20, 2014 at 08:52:54AM -0700, Joe Perches wrote:
> On Sun, 2014-07-20 at 15:01 +0300, Bivolaru Catalin wrote:
> > Fix coding style with regard to missing spaces after , and the column limit
> > that was violated after the first change.
>
> Some checkpatch errors should be ignored.
>
> These are some of them.
>
> This change doesn't make it easier to read
> or to find any array entry.
>
> It's currently in groups of 16 (0x10).
>
> This change would make it very difficult
> to find any particular entry.
>
> It might make some sense to change the last
> line to add a trailing " 0, 0" entry as
> the compiler does to make it a bit clearer
> the table has 128 entries.

I'd rather not change a thing in this table - it has been working as is
for many years.

Thanks.

--
Dmitry