public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
	Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 2/2] Kbuild: Add a option to enable dwarf4
Date: Sun, 20 Jul 2014 21:23:15 +0200	[thread overview]
Message-ID: <20140720192315.GA4679@ravnborg.org> (raw)
In-Reply-To: <1405466172-17055-2-git-send-email-andi@firstfloor.org>

On Wed, Jul 16, 2014 at 01:16:12AM +0200, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
> 
> I found that a lot of unresolvable variables when using gdb on the kernel
> become resolvable when dwarf4 is enabled. So add a Kconfig flag to enable it.
> 
> It definitely increases the debug information size, but on the other
> hand this isn't so bad when debug fusion is used.

Would it not make sense to try to enable degug info like this:
First try -gdwarf-4
If this fails try -gdwarf-3
If this fails try -gdwarf-2
And if this also fails fallback to -g

We could then us a Kconfig option to enable the highest debug level - where 4 for now is the highest.
On the other hand if most people have revent utils then they all have -gdwarf-4 supported
and then it is no big deal.

	Sam

> 
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
> ---
>  Makefile          | 3 +++
>  lib/Kconfig.debug | 9 +++++++++
>  2 files changed, 12 insertions(+)
> 
> diff --git a/Makefile b/Makefile
> index 953659e..9c4080b 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -690,6 +690,9 @@ KBUILD_CFLAGS	+= -g
>  KBUILD_AFLAGS	+= -Wa,-gdwarf-2
>  endif
>  endif
> +ifdef CONFIG_DEBUG_INFO_DWARF4
> +KBUILD_CFLAGS	+= -gdwarf-4
> +endif
Should we sue $(call cc-option ...) here as not all gcc's supports this today?

	Sam

  reply	other threads:[~2014-07-20 19:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-15 23:16 [PATCH 1/2] kbuild: Support split debug info v3 Andi Kleen
2014-07-15 23:16 ` [PATCH 2/2] Kbuild: Add a option to enable dwarf4 Andi Kleen
2014-07-20 19:23   ` Sam Ravnborg [this message]
2014-07-20 21:17     ` Andi Kleen
2014-07-20 19:04 ` [PATCH 1/2] kbuild: Support split debug info v3 Sam Ravnborg
2014-07-20 21:19   ` Andi Kleen
2014-07-23 18:05     ` Sam Ravnborg
2014-07-23 18:28       ` Andi Kleen
2014-07-24  8:10         ` Dirk Gouders
  -- strict thread matches above, loose matches on Subject: below --
2014-07-29 23:11 [PATCH 1/2] kbuild: Support split debug info v4 Andi Kleen
2014-07-29 23:11 ` [PATCH 2/2] Kbuild: Add a option to enable dwarf4 Andi Kleen
2014-07-30 13:38   ` Michal Marek
2014-05-16 22:06 [PATCH 1/2] kbuild: Support split debug info v3 Andi Kleen
2014-05-16 22:06 ` [PATCH 2/2] Kbuild: Add a option to enable dwarf4 Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140720192315.GA4679@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=ak@linux.intel.com \
    --cc=andi@firstfloor.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox