Re: [PATCH] ASoC: arizona: Disable AIF TX/RX before configuring it

Mark Brown
2014-07-17T19:42:42Z

[-- Attachment #1: Type: text/plain, Size: 563 bytes --]

On Wed, Jul 16, 2014 at 01:10:39PM +0100, Richard Fitzgerald wrote:

> If we don't disable the AIF TX/RX then we may fall into a
> situation where the new AIF settings are ignored by the device.
> For example, this problem manifests when switching between
> different sample rates.

So, what this does is momentarily disable the AIF when reconfiguring.
That will glitch any running audio, making me wonder if the driver
shouldn't be returning an error or at least complaining if it has to
reconfigure instead. What's the use case where this might get
triggered?

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]