public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Joel Fernandes <joelf@ti.com>
Cc: Rob Herring <rob.herring@calxeda.com>,
	Linux OMAP List <linux-omap@vger.kernel.org>,
	Linux ARM Kernel List <linux-arm-kernel@lists.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/8] ARM: OMAP2+: timer: Add comment on timer clk parenting
Date: Mon, 21 Jul 2014 04:07:31 -0700	[thread overview]
Message-ID: <20140721110730.GX18374@atomide.com> (raw)
In-Reply-To: <1398216429-4681-4-git-send-email-joelf@ti.com>

* Joel Fernandes <joelf@ti.com> [140422 18:27]:
> Add a comment describing the state of system timer clock parenting.  The code
> following the comment should be deleted once all platforms can do DT boot, and
> specially should not be executed for DT platforms once we can specify default
> clock parents through DT.

I think we can do it already for DT based booting?

Regards,

Tony
 
> Signed-off-by: Joel Fernandes <joelf@ti.com>
> ---
>  arch/arm/mach-omap2/timer.c |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm/mach-omap2/timer.c b/arch/arm/mach-omap2/timer.c
> index f192a41..9fdff5b 100644
> --- a/arch/arm/mach-omap2/timer.c
> +++ b/arch/arm/mach-omap2/timer.c
> @@ -313,6 +313,10 @@ static int __init omap_dm_timer_init_one(struct omap_dm_timer *timer,
>  	if (IS_ERR(timer->fclk))
>  		return PTR_ERR(timer->fclk);
>  
> +	/*
> +	 * Clock reparenting code, goes away for DT-boot atleast,
> +	 * once clock layer can do it through DT.
> +	 */
>  	src = clk_get(NULL, fck_source);
>  	if (IS_ERR(src))
>  		return PTR_ERR(src);
> -- 
> 1.7.9.5
> 

  reply	other threads:[~2014-07-21 11:08 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-23  1:27 [PATCH 0/8] OMAP2+ system timer cleanup series Joel Fernandes
2014-04-23  1:27 ` [PATCH 1/8] ARM: OMAP2+: timer: Add a powerup function Joel Fernandes
2014-07-21 11:00   ` Tony Lindgren
2014-04-23  1:27 ` [PATCH 2/8] ARM: OMAP2+: timer: Simplify clock event/source name setting Joel Fernandes
2014-07-21 11:05   ` Tony Lindgren
2014-04-23  1:27 ` [PATCH 3/8] ARM: OMAP2+: timer: Add comment on timer clk parenting Joel Fernandes
2014-07-21 11:07   ` Tony Lindgren [this message]
2014-04-23  1:27 ` [PATCH 4/8] ARM: OMAP2+: timer: Remove hwmod look-up dependency for DT-boot Joel Fernandes
2014-04-23  1:27 ` [PATCH 5/8] ARM: OMAP2+: timer: Use of_clk_get for DT platforms Joel Fernandes
2014-04-23  1:27 ` [PATCH 6/8] ARM: OMAP2+: timer: Fix error message to not use hwmod structure Joel Fernandes
2014-07-21 11:09   ` Tony Lindgren
2014-04-23  1:27 ` [PATCH 7/8] ARM: OMAP2+: timer: Add fallback for of_clk_get Joel Fernandes
2014-07-21 11:10   ` Tony Lindgren
2014-04-23  1:27 ` [PATCH 8/8] ARM: OMAP2+: timer: Add legacy code for old way of getting fclk Joel Fernandes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140721110730.GX18374@atomide.com \
    --to=tony@atomide.com \
    --cc=joelf@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=rob.herring@calxeda.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox