From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932180AbaGUMbd (ORCPT ); Mon, 21 Jul 2014 08:31:33 -0400 Received: from fw-tnat.austin.arm.com ([217.140.110.23]:20732 "EHLO collaborate-mta1.arm.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932096AbaGUMbb (ORCPT ); Mon, 21 Jul 2014 08:31:31 -0400 Date: Mon, 21 Jul 2014 13:30:56 +0100 From: Catalin Marinas To: Guenter Roeck Cc: "linux-watchdog@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Wim Van Sebroeck , Maxime Ripard , Will Deacon , Arnd Bergmann , Heiko Stuebner , Russell King , Jonas Jensen , Randy Dunlap , Andrew Morton , Steven Rostedt , Ingo Molnar , Dmitry Eremin-Solenikov , David Woodhouse , Tomasz Figa , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v5 0/7] kernel: Add support for restart handler call chain Message-ID: <20140721123056.GF12817@arm.com> References: <1405668856-13738-1-git-send-email-linux@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1405668856-13738-1-git-send-email-linux@roeck-us.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 18, 2014 at 08:34:09AM +0100, Guenter Roeck wrote: > Patch 1 of this series implements the restart handler function. Patches 2 and 3 > implement calling the restart handler chain from arm and arm64 restart code. > > Patch 4 modifies the restart-poweroff driver to no longer call arm_pm_restart > directly but machine_restart. This is done to avoid calling arm_pm_restart > from more than one place. The change makes the driver architecture independent, > so it would be possible to drop the arm dependency from its Kconfig entry. > > Patch 5 and 6 convert existing restart handlers in the watchdog subsystem > to use the restart handler. Patch 7 unexports arm_pm_restart to ensure > that no one gets the idea to implement a restart handler as module. For the current patches: Acked-by: Catalin Marinas Do you plan to convert more of the power/drivers/reset/ code? BTW, is it worth doing something similar for pm_power_off (there is generic code calling it directly, so slightly more complicated than pm_restart)?