From: Lee Jones <lee.jones@linaro.org>
To: Joe Perches <joe@perches.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andy Whitcroft <apw@canonical.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: Allow case labels with ranges
Date: Mon, 21 Jul 2014 14:21:16 +0100 [thread overview]
Message-ID: <20140721132116.GZ30888@lee--X1> (raw)
In-Reply-To: <1405948406.21586.10.camel@joe-AO725>
On Mon, 21 Jul 2014, Joe Perches wrote:
> The MISSING_BREAK / fallthrough test does not support
> gcc's extension for case labels with ranges.
>
> Add it.
>
> Signed-off-by: Joe Perches <joe@perches.com>
> Reported-by: Lee Jones <lee.jones@linaro.org>
> ---
> scripts/checkpatch.pl | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
[...]
Yep, that's much worse [1] - I wish I never mentioned it. ;)
Acked-by: Lee Jones <lee.jones@linaro.org>
[1]
WARNING: Possible switch case/default not preceeded by break or fallthrough comment
#330: FILE: drivers/mfd/tps80031.c:330:
+ case TPS80031_SMPS4_CFG_TRANS ... TPS80031_SMPS3_CFG_VOLTAGE:
WARNING: Possible switch case/default not preceeded by break or fallthrough comment
#331: FILE: drivers/mfd/tps80031.c:331:
+ case TPS80031_BROADCAST_ADDR_ALL ... TPS80031_BROADCAST_ADDR_CLK_RST:
WARNING: Possible switch case/default not preceeded by break or fallthrough comment
#332: FILE: drivers/mfd/tps80031.c:332:
+ case TPS80031_VANA_CFG_TRANS ... TPS80031_LDO7_CFG_VOLTAGE:
WARNING: Possible switch case/default not preceeded by break or fallthrough comment
#333: FILE: drivers/mfd/tps80031.c:333:
+ case TPS80031_REGEN1_CFG_TRANS ... TPS80031_TMP_CFG_STATE:
WARNING: Possible switch case/default not preceeded by break or fallthrough comment
#334: FILE: drivers/mfd/tps80031.c:334:
+ case TPS80031_PREQ1_RES_ASS_A ... TPS80031_PREQ3_RES_ASS_C:
WARNING: Possible switch case/default not preceeded by break or fallthrough comment
#335: FILE: drivers/mfd/tps80031.c:335:
+ case TPS80031_SMPS_OFFSET ... TPS80031_BATDEBOUNCING:
WARNING: Possible switch case/default not preceeded by break or fallthrough comment
#336: FILE: drivers/mfd/tps80031.c:336:
+ case TPS80031_CFG_INPUT_PUPD1 ... TPS80031_CFG_SMPS_PD:
WARNING: Possible switch case/default not preceeded by break or fallthrough comment
#351: FILE: drivers/mfd/tps80031.c:351:
+ case TPS80031_PREQ1_RES_ASS_A ... TPS80031_PREQ3_RES_ASS_C:
WARNING: Possible switch case/default not preceeded by break or fallthrough comment
#352: FILE: drivers/mfd/tps80031.c:352:
+ case TPS80031_SMPS_OFFSET ... TPS80031_BATDEBOUNCING:
WARNING: Possible switch case/default not preceeded by break or fallthrough comment
#353: FILE: drivers/mfd/tps80031.c:353:
+ case TPS80031_CFG_INPUT_PUPD1 ... TPS80031_CFG_SMPS_PD:
WARNING: Possible switch case/default not preceeded by break or fallthrough comment
#366: FILE: drivers/mfd/tps80031.c:366:
+ case TPS80031_TOGGLE1 ... TPS80031_VIBMODE:
WARNING: Possible switch case/default not preceeded by break or fallthrough comment
#367: FILE: drivers/mfd/tps80031.c:367:
+ case TPS80031_PWM1ON ... TPS80031_PWM2OFF:
WARNING: Possible switch case/default not preceeded by break or fallthrough comment
#368: FILE: drivers/mfd/tps80031.c:368:
+ case TPS80031_FG_REG_00 ... TPS80031_FG_REG_11:
WARNING: Possible switch case/default not preceeded by break or fallthrough comment
#369: FILE: drivers/mfd/tps80031.c:369:
+ case TPS80031_INT_STS_A ... TPS80031_INT_MSK_STS_C:
WARNING: Possible switch case/default not preceeded by break or fallthrough comment
#370: FILE: drivers/mfd/tps80031.c:370:
+ case TPS80031_CONTROLLER_CTRL2 ... TPS80031_LED_PWM_CTRL2:
total: 0 errors, 15 warnings, 574 lines checked
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-07-21 13:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-21 11:39 Checkpatch query Lee Jones
2014-07-21 13:06 ` Joe Perches
2014-07-21 13:13 ` [PATCH] checkpatch: Allow case labels with ranges Joe Perches
2014-07-21 13:21 ` Lee Jones [this message]
2014-07-21 14:28 ` Joe Perches
2014-07-21 14:54 ` Lee Jones
[not found] ` <20140721143013.11ec351d47a9f822313247d2@linux-foundation.org>
2014-07-21 23:09 ` [PATCH] checkpatch: Fix false positive MISSING_BREAK warnings with --file Joe Perches
2014-07-22 7:05 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140721132116.GZ30888@lee--X1 \
--to=lee.jones@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox