public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Viresh Kumar <viresh.kumar@linaro.org>
Subject: Re: [PATCH 06/10] nohz: Define meaningful symbol for nohz full timekeeper
Date: Mon, 21 Jul 2014 11:12:55 -0700	[thread overview]
Message-ID: <20140721181255.GH8690@linux.vnet.ibm.com> (raw)
In-Reply-To: <1405730661-9355-7-git-send-email-fweisbec@gmail.com>

On Sat, Jul 19, 2014 at 02:44:17AM +0200, Frederic Weisbecker wrote:
> The nohz full timekeeper is always CPU 0. Lets add it to the list of
> special tick_do_timer_cpu symbols for more self explanatory code.
> 
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>

Sounds like Nicolas Pitre would like to be able to specify the default,
perhaps at build time, but aside from that requested enhancement:

Reviewed-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>

> ---
>  kernel/time/tick-internal.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/kernel/time/tick-internal.h b/kernel/time/tick-internal.h
> index 7ab92b1..6b592a8 100644
> --- a/kernel/time/tick-internal.h
> +++ b/kernel/time/tick-internal.h
> @@ -10,6 +10,7 @@ extern seqlock_t jiffies_lock;
> 
>  #ifdef CONFIG_GENERIC_CLOCKEVENTS_BUILD
> 
> +#define TICK_DO_TIMER_DEFAULT	0
>  #define TICK_DO_TIMER_NONE	-1
>  #define TICK_DO_TIMER_BOOT	-2
> 
> -- 
> 1.8.3.1
> 


  parent reply	other threads:[~2014-07-21 18:13 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-19  0:44 [RFC PATCH 00/10] nohz: Support sysidle (and some more cleanups) Frederic Weisbecker
2014-07-19  0:44 ` [PATCH 01/10] irq_work: Introduce void irq work Frederic Weisbecker
2014-07-21 18:16   ` Paul E. McKenney
2014-07-19  0:44 ` [PATCH 02/10] nohz: Kick full dynticks timer targets with an empty IPI Frederic Weisbecker
2014-07-19  7:19   ` Peter Zijlstra
2014-07-19 13:18     ` Frederic Weisbecker
2014-07-19 13:47       ` Peter Zijlstra
2014-07-19 13:54         ` Frederic Weisbecker
2014-07-19  0:44 ` [PATCH 03/10] rcu: Kick full dynticks CPU on extended grace period with a void IRQ Frederic Weisbecker
2014-07-21 18:16   ` Paul E. McKenney
2014-07-19  0:44 ` [PATCH 04/10] nohz: Appropriate timekeeper kick on sysidle break Frederic Weisbecker
2014-07-21 18:15   ` Paul E. McKenney
2014-07-19  0:44 ` [PATCH 05/10] smp: Fast path check on IPI list Frederic Weisbecker
2014-07-19  0:44 ` [PATCH 06/10] nohz: Define meaningful symbol for nohz full timekeeper Frederic Weisbecker
2014-07-21 18:11   ` Paul E. McKenney
2014-07-21 18:12   ` Paul E. McKenney [this message]
2014-07-25 21:27     ` Frederic Weisbecker
2014-07-19  0:44 ` [PATCH 07/10] nohz: Enforce timekeeping on CPU 0 Frederic Weisbecker
2014-07-19 17:31   ` Nicolas Pitre
2014-07-19 18:31     ` Peter Zijlstra
2014-07-19 18:46       ` Nicolas Pitre
2014-07-19 19:45         ` Peter Zijlstra
2014-07-20  1:07     ` Frederic Weisbecker
2014-07-19  0:44 ` [PATCH 08/10] nohz: Fetch timekeeping max deferment only for timekeeper Frederic Weisbecker
2014-07-19  0:44 ` [PATCH 09/10] nohz: Switch nohz full timekeeper to dynticks idle on top of sysidle detection Frederic Weisbecker
2014-07-21 17:50   ` Paul E. McKenney
2014-07-19  0:44 ` [PATCH 10/10] nohz: Warn on illegal timekeeper switch in nohz full Frederic Weisbecker
2014-07-21 17:51   ` Paul E. McKenney
  -- strict thread matches above, loose matches on Subject: below --
2014-07-28 17:37 [PATCH 00/10] nohz: Support sysidle (+ some more nohz kick cleanups) Frederic Weisbecker
2014-07-28 17:37 ` [PATCH 06/10] nohz: Define meaningful symbol for nohz full timekeeper Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140721181255.GH8690@linux.vnet.ibm.com \
    --to=paulmck@linux.vnet.ibm.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox