From: Borislav Petkov <bp@alien8.de>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>, x86-ml <x86@kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH] x86, TSC: Add a software TSC offset
Date: Mon, 21 Jul 2014 23:52:25 +0200 [thread overview]
Message-ID: <20140721215225.GD11555@pd.tnic> (raw)
In-Reply-To: <CALCETrW91Q=ivYRVFb0WKXgHQO7O+x_HHDy67e90TU6Bte_ecg@mail.gmail.com>
On Mon, Jul 21, 2014 at 02:41:50PM -0700, Andy Lutomirski wrote:
> How will this be compatible with the vdso?
I've never thought about it yet. How compatible would you want it to be
and what do you expect from it?
Remember, this is only attempting to be a hardware workaround for a
smallish number of systems out there. Most of current machines should
have stable and synched TSCs.
> Also, IIRC, rdtscp does not need rdtsc_barrier(), whereas rdtsc does.
> Getting this wrong will be a significant slowdown.
This is too cryptic for me - get_cycles doesn't barrier around the TSC
now either. Again, we will most likely end up not using RDTSCP anyway.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2014-07-21 21:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-19 13:06 [PATCH] x86, TSC: Add a software TSC offset Borislav Petkov
2014-07-19 13:28 ` Borislav Petkov
2014-07-21 19:34 ` Andy Lutomirski
2014-07-21 21:35 ` Borislav Petkov
2014-07-21 21:41 ` Andy Lutomirski
2014-07-21 21:52 ` Borislav Petkov [this message]
2014-07-21 21:56 ` Andy Lutomirski
2014-07-21 22:06 ` Thomas Gleixner
2014-07-21 22:11 ` Thomas Gleixner
2014-07-21 22:14 ` Andy Lutomirski
2014-07-21 22:08 ` Borislav Petkov
2014-07-21 22:13 ` Andy Lutomirski
2014-07-21 22:30 ` Borislav Petkov
2014-07-21 22:43 ` Andy Lutomirski
2014-07-21 23:01 ` Borislav Petkov
2014-07-22 8:00 ` Peter Zijlstra
2014-07-22 7:57 ` Peter Zijlstra
2014-07-22 2:40 ` Steven Rostedt
2014-07-22 8:59 ` Borislav Petkov
2014-07-22 12:05 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140721215225.GD11555@pd.tnic \
--to=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox