public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Guillaume Morin <guillaume@morinfr.org>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	oleg.drokin@intel.com, jinshan.xiong@intel.com,
	lai.siyao@intel.com, joe@perches.com, bergwolf@gmail.com,
	john.hammond@intel.com, sachin.kamat@linaro.org
Subject: Re: [PATCH] staging: llite: rw.c: use gfp_t to store GFP flags
Date: Mon, 21 Jul 2014 19:08:05 -0700	[thread overview]
Message-ID: <20140722020805.GA19215@kroah.com> (raw)
In-Reply-To: <22be101821a4af2c92ca597832cbb720c655418e.1405990074.git.guillaume@morinfr.org>

On Tue, Jul 22, 2014 at 02:57:57AM +0200, Guillaume Morin wrote:
> Use gfp_t to store GPF_* flags instead of unsigned int. 
> This was reported by sparse.
> 
> Signed-off-by: Guillaume Morin <guillaume@morinfr.org>
> ---
>  drivers/staging/lustre/lustre/llite/rw.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/lustre/lustre/llite/rw.c b/drivers/staging/lustre/lustre/llite/rw.c
> index 5616210..3554272 100644
> --- a/drivers/staging/lustre/lustre/llite/rw.c
> +++ b/drivers/staging/lustre/lustre/llite/rw.c
> @@ -496,7 +496,7 @@ static int ll_read_ahead_page(const struct lu_env *env, struct cl_io *io,
>  	struct cl_object *clob  = ll_i2info(mapping->host)->lli_clob;
>  	struct cl_page   *page;
>  	enum ra_stat      which = _NR_RA_STAT; /* keep gcc happy */
> -	unsigned int      gfp_mask;
> +	gfp_t             gfp_mask;

Odd thing is, that function doesn't seem to even use that variable
anywhere...  Can you just remove it entirely?

thanks,

greg k-h

  reply	other threads:[~2014-07-22  2:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-22  0:57 [PATCH] staging: llite: rw.c: use gfp_t to store GFP flags Guillaume Morin
2014-07-22  2:08 ` Greg KH [this message]
2014-07-22  2:47   ` Guillaume Morin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140722020805.GA19215@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=bergwolf@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=guillaume@morinfr.org \
    --cc=jinshan.xiong@intel.com \
    --cc=joe@perches.com \
    --cc=john.hammond@intel.com \
    --cc=lai.siyao@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg.drokin@intel.com \
    --cc=sachin.kamat@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox