* [PATCH] staging: llite: rw.c: use gfp_t to store GFP flags
@ 2014-07-22 0:57 Guillaume Morin
2014-07-22 2:08 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Guillaume Morin @ 2014-07-22 0:57 UTC (permalink / raw)
To: gregkh
Cc: Guillaume Morin, devel, linux-kernel, oleg.drokin, jinshan.xiong,
lai.siyao, joe, bergwolf, john.hammond, sachin.kamat
Use gfp_t to store GPF_* flags instead of unsigned int.
This was reported by sparse.
Signed-off-by: Guillaume Morin <guillaume@morinfr.org>
---
drivers/staging/lustre/lustre/llite/rw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/llite/rw.c b/drivers/staging/lustre/lustre/llite/rw.c
index 5616210..3554272 100644
--- a/drivers/staging/lustre/lustre/llite/rw.c
+++ b/drivers/staging/lustre/lustre/llite/rw.c
@@ -496,7 +496,7 @@ static int ll_read_ahead_page(const struct lu_env *env, struct cl_io *io,
struct cl_object *clob = ll_i2info(mapping->host)->lli_clob;
struct cl_page *page;
enum ra_stat which = _NR_RA_STAT; /* keep gcc happy */
- unsigned int gfp_mask;
+ gfp_t gfp_mask;
int rc = 0;
const char *msg = NULL;
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: llite: rw.c: use gfp_t to store GFP flags
2014-07-22 0:57 [PATCH] staging: llite: rw.c: use gfp_t to store GFP flags Guillaume Morin
@ 2014-07-22 2:08 ` Greg KH
2014-07-22 2:47 ` Guillaume Morin
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2014-07-22 2:08 UTC (permalink / raw)
To: Guillaume Morin
Cc: devel, linux-kernel, oleg.drokin, jinshan.xiong, lai.siyao, joe,
bergwolf, john.hammond, sachin.kamat
On Tue, Jul 22, 2014 at 02:57:57AM +0200, Guillaume Morin wrote:
> Use gfp_t to store GPF_* flags instead of unsigned int.
> This was reported by sparse.
>
> Signed-off-by: Guillaume Morin <guillaume@morinfr.org>
> ---
> drivers/staging/lustre/lustre/llite/rw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lustre/llite/rw.c b/drivers/staging/lustre/lustre/llite/rw.c
> index 5616210..3554272 100644
> --- a/drivers/staging/lustre/lustre/llite/rw.c
> +++ b/drivers/staging/lustre/lustre/llite/rw.c
> @@ -496,7 +496,7 @@ static int ll_read_ahead_page(const struct lu_env *env, struct cl_io *io,
> struct cl_object *clob = ll_i2info(mapping->host)->lli_clob;
> struct cl_page *page;
> enum ra_stat which = _NR_RA_STAT; /* keep gcc happy */
> - unsigned int gfp_mask;
> + gfp_t gfp_mask;
Odd thing is, that function doesn't seem to even use that variable
anywhere... Can you just remove it entirely?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: llite: rw.c: use gfp_t to store GFP flags
2014-07-22 2:08 ` Greg KH
@ 2014-07-22 2:47 ` Guillaume Morin
0 siblings, 0 replies; 3+ messages in thread
From: Guillaume Morin @ 2014-07-22 2:47 UTC (permalink / raw)
To: Greg KH
Cc: Guillaume Morin, devel, linux-kernel, oleg.drokin, jinshan.xiong,
lai.siyao, joe, bergwolf, john.hammond, sachin.kamat
On 21 Jul 19:08, Greg KH wrote:
> Odd thing is, that function doesn't seem to even use that variable
> anywhere... Can you just remove it entirely?
Oh that's right. Resubmitted.
Thanks
Guillaume.
--
Guillaume Morin <guillaume@morinfr.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-07-22 2:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-22 0:57 [PATCH] staging: llite: rw.c: use gfp_t to store GFP flags Guillaume Morin
2014-07-22 2:08 ` Greg KH
2014-07-22 2:47 ` Guillaume Morin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox