From: Lee Jones <lee.jones@linaro.org>
To: Joe Perches <joe@perches.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] checkpatch: Fix false positive MISSING_BREAK warnings with --file
Date: Tue, 22 Jul 2014 08:05:30 +0100 [thread overview]
Message-ID: <20140722070530.GB28529@lee--X1> (raw)
In-Reply-To: <1405984193.30871.10.camel@joe-AO725>
On Mon, 21 Jul 2014, Joe Perches wrote:
> Using --file mode can give false positives with MISSING_BREAK
> fall-through warnings on simple but long multiple consecutive
> case statements.
>
> Look for all lines before a case statement for a switch
> or a statement when using --file mode.
>
> Fix a misspelling of preceded while there.
>
> Signed-off-by: Joe Perches <joe@perches.com>
> Reported-by: Lee Jones <lee.jones@linaro.org>
Solution works for me.
> total: 0 errors, 0 warnings, 574 lines checked
>
> drivers/mfd/tps80031.c has no obvious style problems and is ready
> for submission.
Acked-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2014-07-22 7:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-21 11:39 Checkpatch query Lee Jones
2014-07-21 13:06 ` Joe Perches
2014-07-21 13:13 ` [PATCH] checkpatch: Allow case labels with ranges Joe Perches
2014-07-21 13:21 ` Lee Jones
2014-07-21 14:28 ` Joe Perches
2014-07-21 14:54 ` Lee Jones
[not found] ` <20140721143013.11ec351d47a9f822313247d2@linux-foundation.org>
2014-07-21 23:09 ` [PATCH] checkpatch: Fix false positive MISSING_BREAK warnings with --file Joe Perches
2014-07-22 7:05 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140722070530.GB28529@lee--X1 \
--to=lee.jones@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox