From: Borislav Petkov <bp@alien8.de>
To: Wanpeng Li <wanpeng.li@linux.intel.com>
Cc: "Chen, Gong" <gong.chen@linux.intel.com>,
hpa@zytor.com, Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
x86@kernel.org,
Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>,
David Rientjes <rientjes@google.com>,
Prarit Bhargava <prarit@redhat.com>,
Steven Rostedt <srostedt@redhat.com>,
Jan Kiszka <jan.kiszka@siemens.com>,
Toshi Kani <toshi.kani@hp.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] x86, hotplug: fix llc shared map unreleased during cpu hotplug
Date: Tue, 22 Jul 2014 11:44:25 +0200 [thread overview]
Message-ID: <20140722094425.GC6462@pd.tnic> (raw)
In-Reply-To: <20140722093023.GA6841@kernel>
On Tue, Jul 22, 2014 at 05:30:23PM +0800, Wanpeng Li wrote:
> On Tue, Jul 22, 2014 at 04:46:41AM -0400, Chen, Gong wrote:
> >On Tue, Jul 22, 2014 at 04:04:52PM +0800, Wanpeng Li wrote:
> >> Subject: [PATCH v2] x86, hotplug: fix llc shared map unreleased during cpu
> >> hotplug
> >
> >See this link:
> >https://lkml.org/lkml/2014/7/17/78
>
> Interesting, thanks for your pointing out.
Well, we might end up doing both.
Yasuaki's patch makes the core numbering stable which makes a lot of
sense in and of itself.
However, if some code somewhere relies implicitly on the fact that a set
bit in LLC mask means that core is online and goes and does stuff on it,
Wanpeng's reported splat will happen.
So probably we will have to have *stable* core numbers *and* clear the
LLC mask in order to be on the safe side of things.
Thanks.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2014-07-22 9:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-22 8:04 [PATCH v2] x86, hotplug: fix llc shared map unreleased during cpu hotplug Wanpeng Li
2014-07-22 8:46 ` Chen, Gong
2014-07-22 9:30 ` Wanpeng Li
2014-07-22 9:44 ` Borislav Petkov [this message]
2014-07-23 8:56 ` Yasuaki Ishimatsu
2014-07-29 7:06 ` Wanpeng Li
2014-07-29 7:31 ` Yasuaki Ishimatsu
2014-07-29 8:33 ` Borislav Petkov
2014-07-29 9:02 ` Wanpeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140722094425.GC6462@pd.tnic \
--to=bp@alien8.de \
--cc=gong.chen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=jan.kiszka@siemens.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=prarit@redhat.com \
--cc=rientjes@google.com \
--cc=srostedt@redhat.com \
--cc=toshi.kani@hp.com \
--cc=wanpeng.li@linux.intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox