From: Benjamin LaHaise <bcrl@kvack.org>
To: Gu Zheng <guz.fnst@cn.fujitsu.com>
Cc: axboe@kernel.dk, akpm@linux-foundation.org, linux-aio@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] aio: use the macro rather than the inline magic number
Date: Tue, 22 Jul 2014 10:11:50 -0400 [thread overview]
Message-ID: <20140722141150.GC26030@kvack.org> (raw)
In-Reply-To: <1405996804-8262-2-git-send-email-guz.fnst@cn.fujitsu.com>
On Tue, Jul 22, 2014 at 10:40:02AM +0800, Gu Zheng wrote:
> Signed-off-by: Gu Zheng <guz.fnst@cn.fujitsu.com>
You're missing a commit message here. The patch is otherwise fine.
-ben
> ---
> fs/aio.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/aio.c b/fs/aio.c
> index ad35876..1dc6158 100644
> --- a/fs/aio.c
> +++ b/fs/aio.c
> @@ -201,7 +201,7 @@ static struct dentry *aio_mount(struct file_system_type *fs_type,
> static const struct dentry_operations ops = {
> .d_dname = simple_dname,
> };
> - return mount_pseudo(fs_type, "aio:", NULL, &ops, 0xa10a10a1);
> + return mount_pseudo(fs_type, "aio:", NULL, &ops, AIO_RING_MAGIC);
> }
>
> /* aio_setup
> --
> 1.7.7
--
"Thought is the essence of where you are now."
prev parent reply other threads:[~2014-07-22 14:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1405996804-8262-1-git-send-email-guz.fnst@cn.fujitsu.com>
[not found] ` <1405996804-8262-4-git-send-email-guz.fnst@cn.fujitsu.com>
2014-07-22 13:48 ` [PATCH 4/4] aio: use iovec array rather than the single one Jeff Moyer
2014-07-22 15:20 ` Jeff Moyer
2014-07-23 4:05 ` Gu Zheng
2014-07-22 13:53 ` [PATCH 1/4] aio: remove the needless registration of ring file's private_data Jeff Moyer
[not found] ` <1405996804-8262-3-git-send-email-guz.fnst@cn.fujitsu.com>
2014-07-22 13:54 ` [PATCH 3/4] aio: fix some comments Jeff Moyer
2014-07-22 14:12 ` Benjamin LaHaise
2014-07-23 3:58 ` Gu Zheng
[not found] ` <1405996804-8262-2-git-send-email-guz.fnst@cn.fujitsu.com>
2014-07-22 13:54 ` [PATCH 2/4] aio: use the macro rather than the inline magic number Jeff Moyer
2014-07-25 3:13 ` Ming Lei
2014-07-25 5:54 ` Gu Zheng
2014-07-22 14:11 ` Benjamin LaHaise [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140722141150.GC26030@kvack.org \
--to=bcrl@kvack.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=guz.fnst@cn.fujitsu.com \
--cc=linux-aio@kvack.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox