From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Guillaume Clement <gclement@baobob.org>
Cc: Forest Bond <forest@alittletooquiet.net>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] staging: vt6655: change type of PortOffset to void __iomem *
Date: Tue, 22 Jul 2014 15:01:51 -0700 [thread overview]
Message-ID: <20140722220151.GA29251@kroah.com> (raw)
In-Reply-To: <1406059710-30903-2-git-send-email-gclement@baobob.org>
On Tue, Jul 22, 2014 at 10:08:26PM +0200, Guillaume Clement wrote:
> PortOffset was an unsigned long, but used as an pointer to io
> memory. Sometimes it was not properly cast before use, which caused
> many warning by sparse.
>
> By updating its type to void __iomem *, and reflecting the changes
> where it is needed, this removes most of those warnings.
Nice job, that's the correct way to fix this.
greg k-h
next prev parent reply other threads:[~2014-07-22 22:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-22 20:08 [PATCH 0/5] staging: vt6655: fix sparse issues Guillaume Clement
2014-07-22 20:08 ` [PATCH 1/5] staging: vt6655: change type of PortOffset to void __iomem * Guillaume Clement
2014-07-22 22:01 ` Greg Kroah-Hartman [this message]
2014-07-22 20:08 ` [PATCH 2/5] staging: vt6655:fix warning for unexported non-static functions Guillaume Clement
2014-07-22 20:08 ` [PATCH 3/5] staging: vt6655: statify some variables Guillaume Clement
2014-07-22 20:08 ` [PATCH 4/5] staging: vt6655: remove unused functions Guillaume Clement
2014-07-22 20:08 ` [PATCH 5/5] staging: vt6655: Fix unused function warning Guillaume Clement
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140722220151.GA29251@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=forest@alittletooquiet.net \
--cc=gclement@baobob.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox