From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932395AbaGVXYU (ORCPT ); Tue, 22 Jul 2014 19:24:20 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:49828 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932171AbaGVXYT (ORCPT ); Tue, 22 Jul 2014 19:24:19 -0400 Date: Tue, 22 Jul 2014 16:24:18 -0700 From: Greg KH To: Enric Balletbo i Serra Cc: pavan_savoy@ti.com, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH] drivers/misc/ti-st: Load firmware from ti-connectivity directory. Message-ID: <20140722232418.GA18997@kroah.com> References: <1406027318-26186-1-git-send-email-eballetbo@iseebcn.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1406027318-26186-1-git-send-email-eballetbo@iseebcn.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 22, 2014 at 01:08:38PM +0200, Enric Balletbo i Serra wrote: > Looks like the default location for TI firmware is inside the ti-connectivity > directory, to be coherent with other firmware request used by TI drivers, load > the TIInit firmware from this directory instead of /lib/firmware directly. > > Signed-off-by: Enric Balletbo i Serra > --- > drivers/misc/ti-st/st_kim.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/misc/ti-st/st_kim.c b/drivers/misc/ti-st/st_kim.c > index 9d3dbb2..fa6a900 100644 > --- a/drivers/misc/ti-st/st_kim.c > +++ b/drivers/misc/ti-st/st_kim.c > @@ -244,7 +244,8 @@ static long read_local_version(struct kim_data_s *kim_gdata, char *bts_scr_name) > if (version & 0x8000) > maj_ver |= 0x0008; > > - sprintf(bts_scr_name, "TIInit_%d.%d.%d.bts", chip, maj_ver, min_ver); > + sprintf(bts_scr_name, "ti-connectivity/TIInit_%d.%d.%d.bts", > + chip, maj_ver, min_ver); Can I get an ack from a ti.com address to verify that this is where the driver really is? thanks, greg k-h