From: "Antoine Ténart" <antoine.tenart@free-electrons.com>
To: Bin Liu <binmlist@gmail.com>
Cc: "Antoine Ténart" <antoine.tenart@free-electrons.com>,
balbi@ti.com, gregkh@linuxfoundation.org,
Peter.Chen@freescale.com, kishon@ti.com,
stern@rowland.harvard.edu, alexandre.belloni@free-electrons.com,
thomas.petazzoni@free-electrons.com, zmxu@marvell.com,
jszhang@marvell.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] usb: move the OTG state from the USB PHY to the OTG structure
Date: Wed, 23 Jul 2014 09:08:31 +0200 [thread overview]
Message-ID: <20140723070831.GA10816@kwain> (raw)
In-Reply-To: <CADYTM3ZijsqSUTvBEscJCP94aWCPahPJ1se+g0+ssqwcE_yAxg@mail.gmail.com>
Hi,
On Tue, Jul 22, 2014 at 04:33:54PM -0500, Bin Liu wrote:
> On Wed, Jul 9, 2014 at 5:17 AM, Antoine Ténart
> <antoine.tenart@free-electrons.com> wrote:
> > diff --git a/drivers/usb/chipidea/debug.c b/drivers/usb/chipidea/debug.c
> > index 7cccab6ff308..9a9702773e43 100644
> > --- a/drivers/usb/chipidea/debug.c
> > +++ b/drivers/usb/chipidea/debug.c
> > @@ -219,8 +219,7 @@ int ci_otg_show(struct seq_file *s, void *unused)
> > fsm = &ci->fsm;
> >
> > /* ------ State ----- */
> > - seq_printf(s, "OTG state: %s\n\n",
>
> Is this line removed by accident?
>
> > - usb_otg_state_string(ci->transceiver->state));
> > + usb_otg_state_string(ci->transceiver->otg.state));
> >
> > /* ------ State Machine Variables ----- */
It is. I'll fix this.
Thanks!
Antoine
--
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-07-23 7:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-09 10:17 [PATCH 0/4] usb: add support for the generic PHY framework Antoine Ténart
2014-07-09 10:17 ` [PATCH 1/4] usb: move the OTG state from the USB PHY to the OTG structure Antoine Ténart
2014-07-10 13:40 ` Felipe Balbi
2014-07-10 13:47 ` Antoine Ténart
2014-07-16 15:02 ` Felipe Balbi
2014-07-15 11:27 ` Peter Chen
2014-07-22 21:33 ` Bin Liu
2014-07-23 7:08 ` Antoine Ténart [this message]
2014-07-09 10:17 ` [PATCH 2/4] usb: add support to the PHY framework for OTG Antoine Ténart
2014-07-10 13:41 ` Felipe Balbi
2014-07-09 10:17 ` [PATCH 3/4] usb: add support to the PHY framework for HCD Antoine Ténart
2014-07-09 14:41 ` Alan Stern
2014-07-09 15:08 ` Antoine Ténart
2014-07-14 9:08 ` Vivek Gautam
2014-07-15 9:09 ` Antoine Ténart
2014-07-09 10:17 ` [PATCH 4/4] usb: chipidea: add support to the PHY framework for ChipIdea Antoine Ténart
2014-07-10 13:42 ` Felipe Balbi
2014-07-10 13:51 ` Antoine Ténart
2014-07-10 13:56 ` Felipe Balbi
2014-07-10 14:01 ` Antoine Ténart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140723070831.GA10816@kwain \
--to=antoine.tenart@free-electrons.com \
--cc=Peter.Chen@freescale.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=balbi@ti.com \
--cc=binmlist@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jszhang@marvell.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=thomas.petazzoni@free-electrons.com \
--cc=zmxu@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox