Re: [PATCH] staging: bcm : Transmit.c : fixed coding style problem

Dan Carpenter
2014-07-23T14:08:47Z

Subject is too general. Which coding style issue did you fix?

On Wed, Jul 23, 2014 at 07:22:30PM +0530, sudip wrote:

Use your full name. "Sudip Mukherjee" not just "sudip".

> applies to next-20140723

Leave this out.

>
>
> Signed-off-by: sudip <sudipm.mukherjee@gmail.com>

Use your real name again.

> ---
> drivers/staging/bcm/Transmit.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/bcm/Transmit.c b/drivers/staging/bcm/Transmit.c
> index 05fae92..10586f8 100644
> --- a/drivers/staging/bcm/Transmit.c
> +++ b/drivers/staging/bcm/Transmit.c
> @@ -89,7 +89,8 @@ int SendControlPacket(struct bcm_mini_adapter *Adapter, char *pControlPacket)
> * to the target via the host h/w interface.
> * @return zero(success) or -ve value(failure)
> */
> -int SetupNextSend(struct bcm_mini_adapter *Adapter, struct sk_buff *Packet, USHORT Vcid)
> +int SetupNextSend(struct bcm_mini_adapter *Adapter,
> + struct sk_buff *Packet, USHORT Vcid)
> {
> int status = 0;
> bool bHeaderSupressionEnabled = false;
> @@ -205,7 +206,8 @@ int tx_pkt_handler(struct bcm_mini_adapter *Adapter)
> int status = 0;
>
> while (!kthread_should_stop()) {
> - /* FIXME - the timeout looks like workaround for racey usage of TxPktAvail */
> + /* FIXME - the timeout looks like workaround
> + for racey usage of TxPktAvail */

This is not proper style for muti-line comments.

regards,
dan carpenter