Re: [PATCH] usb-core: Revert "usb-core: Remove Fix mes in file hcd.c"

Greg KH
2014-07-24T20:56:22Z

On Thu, Jul 24, 2014 at 12:20:37PM -0400, Sasha Levin wrote:
> On 07/24/2014 12:04 PM, Greg KH wrote:
> >> If you add a revert and leave the original broken commit in, wouldn't it cause issues
> >> > for anyone trying to bisect a build breakage?
> > Yes it does.
> >
> > I can not rebase my public trees, nor should any other kernel
> > maintainer. This has been true for _many_ years.
>
> This isn't the case with -mm, for example, where the tree does get edited
> quite often.

-mm is a set of quilt patches, not a git tree.

> What stops you from editing it even if people are working on it? 'git pull --rebase'
> will dtrt for both the ff and the non-ff case, where the non-ff case would have happen
> either way if those people kept tracking your -next tree.

No, subsystem maintainers are not allowed to break their trees like
this, unless something really major happens that requires it.

Again, it's been this way for years, and is one of the requirements of
subsystem maintainers. If you want a "testing" branch, use a "testing"
branch, but don't cause problems on your "real" branch or problems will
happen.

thanks,

greg k-h