* [PATCH 1/1] Staging: comedi: amplc_pc236: a blank line inserted
@ 2014-07-23 2:06 Sam Asadi
2014-07-24 0:55 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Sam Asadi @ 2014-07-23 2:06 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, Sam Asadi
A 'Missing a blank line after declarations' warning fixed by inserting
a blank line after struct pointer declaration.
Signed-off-by: Sam Asadi <asadi.samuel@gmail.com>
---
drivers/staging/comedi/drivers/amplc_pc236.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/comedi/drivers/amplc_pc236.c b/drivers/staging/comedi/drivers/amplc_pc236.c
index c9a96ad..d0f81f8 100644
--- a/drivers/staging/comedi/drivers/amplc_pc236.c
+++ b/drivers/staging/comedi/drivers/amplc_pc236.c
@@ -515,6 +515,7 @@ static void pc236_detach(struct comedi_device *dev)
comedi_legacy_detach(dev);
} else if (is_pci_board(thisboard)) {
struct pci_dev *pcidev = comedi_to_pci_dev(dev);
+
if (dev->irq)
free_irq(dev->irq, dev);
comedi_pci_disable(dev);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] Staging: comedi: amplc_pc236: a blank line inserted
2014-07-23 2:06 [PATCH 1/1] Staging: comedi: amplc_pc236: a blank line inserted Sam Asadi
@ 2014-07-24 0:55 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2014-07-24 0:55 UTC (permalink / raw)
To: Sam Asadi; +Cc: devel, linux-kernel
On Wed, Jul 23, 2014 at 05:06:28AM +0300, Sam Asadi wrote:
> A 'Missing a blank line after declarations' warning fixed by inserting
> a blank line after struct pointer declaration.
>
> Signed-off-by: Sam Asadi <asadi.samuel@gmail.com>
> ---
> drivers/staging/comedi/drivers/amplc_pc236.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/comedi/drivers/amplc_pc236.c b/drivers/staging/comedi/drivers/amplc_pc236.c
> index c9a96ad..d0f81f8 100644
> --- a/drivers/staging/comedi/drivers/amplc_pc236.c
> +++ b/drivers/staging/comedi/drivers/amplc_pc236.c
> @@ -515,6 +515,7 @@ static void pc236_detach(struct comedi_device *dev)
> comedi_legacy_detach(dev);
> } else if (is_pci_board(thisboard)) {
> struct pci_dev *pcidev = comedi_to_pci_dev(dev);
> +
> if (dev->irq)
> free_irq(dev->irq, dev);
> comedi_pci_disable(dev);
This is already in my tree, sorry :(
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-24 0:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-23 2:06 [PATCH 1/1] Staging: comedi: amplc_pc236: a blank line inserted Sam Asadi
2014-07-24 0:55 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox