Re: [PATCH 2/2] ARM: mvebu: Added dts defintion for Lenovo Iomega ix4-300d NAS

Andrew Lunn
2014-07-23T22:47:47Z

> + i2c@11000 {
> + compatible = "marvell,mv78230-a0-i2c",
> + "marvell,mv64xxx-i2c";

Ah sorry, i missed this first time. Do you really need
"marvell,mv78230-a0-i2c"?

Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt says:

- "marvell,mv78230-a0-i2c"
* Note: Only use "marvell,mv78230-a0-i2c" for a
very rare, initial version of the SoC which
had broken offload support. Linux
auto-detects this and sets it appropriately.

So i don't think you should have this hear.

Gregory, please could you comment.

> + power-led {
> + label = "ix4-300d:power";

It is normal to include the colour, and you did for all the other
LEDs.

Andrew