public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Ingo Molnar <mingo@kernel.org>, Paul Mackerras <paulus@samba.org>,
	Namhyung Kim <namhyung.kim@lge.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCHSET 0/6] perf tools: Honor column width setting
Date: Thu, 24 Jul 2014 15:11:20 +0200	[thread overview]
Message-ID: <20140724131120.GD7652@krava.brq.redhat.com> (raw)
In-Reply-To: <87r41cjzez.fsf@sejong.aot.lge.com>

On Wed, Jul 23, 2014 at 04:40:36PM +0900, Namhyung Kim wrote:
> Hi Jiri,
> 
> On Mon, 21 Jul 2014 11:07:55 +0200, Jiri Olsa wrote:
> > On Wed, Jul 09, 2014 at 02:28:08PM +0900, Namhyung Kim wrote:
> >> Hello,
> >> 
> >> This patchset is to control perf report/top output column width by
> >> -w/--column-widths option so that it can fit into the terminal size.
> >> The -w option is there for perf report but it ignored by recent output
> >> field changed due to some reason.  This patchset fixes it and supports
> >> perf top also.
> >> 
> >> This is sometimes useful if your terminal is small and there's some
> >> C++ applications which have amazingly long symbol names.  Without this
> >> patchset user might not see those symbols on TUI, since it maps
> >> left/right arrow keys to other functions.
> >> 
> >> The -w option sets column width starting from the first column
> >> (overhead or optional overhead_children column unless -F option is
> >> given).  It doesn't make sense to limit those overhead columns so it's
> >> not a hard-limit for them.  But it *is* a hard-limit for other columns
> >> such as comm, dso, symbol, and so on.  One can use 0 not to
> >> limit/force a width for those columns.
> >
> > hi,
> > I've got broken TUI output for "perf report --group" 
> >
> > Samples: 17  of event 'anon group { cycles, instructions }', Event count (approx.): 9145256
> >  56.44% 31.59%  ls  libc-2.17.so       [.] __strcoll_l
> >  39.94% 0.00%  ls  ld-2.17.so         [.] _dl_new_object
> >  3.48% 0.00%  ls  [kernel.kallsyms]  [k] setup_arg_pages
> >  0.14% 0.33%  ls  [kernel.kallsyms]  [k] native_write_msr_safe
> >  0.00% 30.17%  ls  [kernel.kallsyms]  [k] security_inode_permission
> >  0.00% 29.78%  ls  ls                 [.] indent
> >  0.00% 8.12%  ls  [kernel.kallsyms]  [k] __slab_alloc
> >
> > I have 'show-headers' set to false in ~/.perfconfig and the output
> > got fixed after displaying headers by pressing 'H'
> 
> Argh, you're right.  It should be fixed with this patch:

yep, that fixed that for me

thanks,
jirka

  reply	other threads:[~2014-07-24 13:11 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-09  5:28 [PATCHSET 0/6] perf tools: Honor column width setting Namhyung Kim
2014-07-09  5:28 ` [PATCH 1/6] perf tools: Left-align output contents Namhyung Kim
2014-07-09  5:28 ` [PATCH 2/6] perf tools: Make __hpp__fmt() receive an additional len argument Namhyung Kim
2014-07-09  5:28 ` [PATCH 3/6] perf tools: Save column length in perf_hpp_fmt Namhyung Kim
2014-07-24 12:10   ` Jiri Olsa
2014-07-24 15:46     ` Namhyung Kim
2014-07-24 15:58       ` Jiri Olsa
2014-07-09  5:28 ` [PATCH 4/6] perf report: Honor column width setting Namhyung Kim
2014-07-24 12:47   ` Jiri Olsa
2014-07-24 15:51     ` Namhyung Kim
2014-07-24 12:57   ` Jiri Olsa
2014-07-24 13:57     ` Arnaldo Carvalho de Melo
2014-07-24 14:49       ` Jiri Olsa
2014-07-24 15:41         ` Namhyung Kim
2014-07-24 15:58           ` Jiri Olsa
2014-07-24 19:14             ` Arnaldo Carvalho de Melo
2014-07-09  5:28 ` [PATCH 5/6] perf top: Add -w option for setting column width Namhyung Kim
2014-07-09  5:28 ` [PATCH 6/6] perf tools: Add name field into perf_hpp_fmt Namhyung Kim
2014-07-21  9:07 ` [PATCHSET 0/6] perf tools: Honor column width setting Jiri Olsa
2014-07-23  7:40   ` Namhyung Kim
2014-07-24 13:11     ` Jiri Olsa [this message]
2014-07-24 13:59 ` Arnaldo Carvalho de Melo
2014-07-24 15:42   ` Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140724131120.GD7652@krava.brq.redhat.com \
    --to=jolsa@redhat.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung.kim@lge.com \
    --cc=namhyung@kernel.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox