From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759351AbaGXN7s (ORCPT ); Thu, 24 Jul 2014 09:59:48 -0400 Received: from mail.kernel.org ([198.145.19.201]:42887 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759295AbaGXN7q (ORCPT ); Thu, 24 Jul 2014 09:59:46 -0400 Date: Thu, 24 Jul 2014 10:59:41 -0300 From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Peter Zijlstra , Ingo Molnar , Paul Mackerras , Namhyung Kim , LKML , Jiri Olsa Subject: Re: [PATCHSET 0/6] perf tools: Honor column width setting Message-ID: <20140724135941.GT20303@kernel.org> References: <1404883694-5342-1-git-send-email-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1404883694-5342-1-git-send-email-namhyung@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Jul 09, 2014 at 02:28:08PM +0900, Namhyung Kim escreveu: > Hello, > > This patchset is to control perf report/top output column width by > -w/--column-widths option so that it can fit into the terminal size. > The -w option is there for perf report but it ignored by recent output > field changed due to some reason. This patchset fixes it and supports > perf top also. > > This is sometimes useful if your terminal is small and there's some > C++ applications which have amazingly long symbol names. Without this > patchset user might not see those symbols on TUI, since it maps > left/right arrow keys to other functions. > > The -w option sets column width starting from the first column > (overhead or optional overhead_children column unless -F option is > given). It doesn't make sense to limit those overhead columns so it's > not a hard-limit for them. But it *is* a hard-limit for other columns > such as comm, dso, symbol, and so on. One can use 0 not to > limit/force a width for those columns. Due to the issues pointed out, will wait for a v2 patchset, ok? - Arnaldo