From: "Theodore Ts'o" <tytso@mit.edu>
To: Pavel Machek <pavel@ucw.cz>
Cc: linux-kernel@vger.kernel.org, adilger.kernel@dilger.ca,
linux-ext4@vger.kernel.org, jack@suse.cz
Subject: Re: Is warn_on() right reply for i/o error?
Date: Thu, 24 Jul 2014 15:29:38 -0400 [thread overview]
Message-ID: <20140724192938.GM6673@thunk.org> (raw)
In-Reply-To: <20140724152721.GA4771@amd.pavel.ucw.cz>
On Thu, Jul 24, 2014 at 05:27:22PM +0200, Pavel Machek wrote:
> Hi!
>
> Just... I know, I should not be unscrewing hard drive cover while
> operating.
>
> But on the other hand... WARN_ON() does not sound like right reply for
> a disk failure... right?
Actually, it can be worse than that. If a hard drive disappears out
from under you while writeback is happening, it's possible to get
crashes in bdi_writeack_workfn() because you can have races between
bdi_unregister() and bdi_writeback_workfn(), since the latter requeues
itself and flush_delayed_work() can return while
bdi_writeback_workfn() is still executing.
This looks like it's a related problem, where the block device gets
unregistered (and this happens in the block device layer without it
telling the file system that the disk drive is about to disappear out
from under it), and occasionally, Bad Stuff Happens. :-(
- Ted
next prev parent reply other threads:[~2014-07-24 19:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-24 15:27 Is warn_on() right reply for i/o error? Pavel Machek
2014-07-24 19:29 ` Theodore Ts'o [this message]
2014-07-29 12:05 ` Jan Kara
2014-07-29 12:04 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140724192938.GM6673@thunk.org \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox