From: Dan Carpenter <dan.carpenter@oracle.com>
To: Seunghun Lee <waydi1@gmail.com>
Cc: gregkh@linuxfoundation.org, lidza.louina@gmail.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] staging: dgng: Fix Macros with complex values should be enclosed in parenthesis
Date: Fri, 25 Jul 2014 13:49:32 +0300 [thread overview]
Message-ID: <20140725104932.GW25880@mwanda> (raw)
In-Reply-To: <1406215613-9314-1-git-send-email-waydi1@gmail.com>
On Fri, Jul 25, 2014 at 12:26:51AM +0900, Seunghun Lee wrote:
> This patch fixes a checkpatch errors
> "Macros with complex values should be enclosed in parenthesis"
>
> Signed-off-by: Seunghun Lee <waydi1@gmail.com>
> ---
> drivers/staging/dgnc/dgnc_driver.h | 40 ++++++++++++------------
> drivers/staging/dgnc/digi.h | 60 ++++++++++++++++++------------------
> drivers/staging/dgnc/dpacompat.h | 12 ++++----
> 3 files changed, 56 insertions(+), 56 deletions(-)
>
> diff --git a/drivers/staging/dgnc/dgnc_driver.h b/drivers/staging/dgnc/dgnc_driver.h
> index fe5ea90..f7730a1 100644
> --- a/drivers/staging/dgnc/dgnc_driver.h
> +++ b/drivers/staging/dgnc/dgnc_driver.h
> @@ -111,32 +111,32 @@
> #endif
>
> #if defined TRC_TO_KMEM
> -#define PRINTF_TO_KMEM(args) dgnc_tracef args
> +#define PRINTF_TO_KMEM(args) do { dgnc_tracef args } while (0)
This is *so* nasty... I suspect the only reason it works is because
TRC_TO_KMEM is never defined.
regards,
dan carpenter
prev parent reply other threads:[~2014-07-25 10:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-24 15:26 [PATCH 1/3] staging: dgng: Fix Macros with complex values should be enclosed in parenthesis Seunghun Lee
2014-07-24 15:26 ` [PATCH 2/3] staging: dgnc: Fix do not initialise statics to 0 or NULL Seunghun Lee
2014-07-24 16:44 ` Paul Bolle
2014-07-24 15:26 ` [PATCH 3/3] staging: dgnc: Fix space required after that ',' Seunghun Lee
2014-07-24 17:52 ` [PATCH 1/3] staging: dgng: Fix Macros with complex values should be enclosed in parenthesis Joe Perches
2014-07-25 10:49 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140725104932.GW25880@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=lidza.louina@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=waydi1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox