From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760096AbaGYMWz (ORCPT ); Fri, 25 Jul 2014 08:22:55 -0400 Received: from cantor2.suse.de ([195.135.220.15]:39835 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752069AbaGYMWy (ORCPT ); Fri, 25 Jul 2014 08:22:54 -0400 Date: Fri, 25 Jul 2014 13:22:49 +0100 From: Mel Gorman To: Vlastimil Babka Cc: linux-mm@kvack.org, Andrew Morton , David Rientjes , linux-kernel@vger.kernel.org, Minchan Kim , Joonsoo Kim , Michal Nazarewicz , Naoya Horiguchi , Christoph Lameter , Rik van Riel , Zhang Yanfei Subject: Re: [PATCH V4 03/15] mm, compaction: do not count compact_stall if all zones skipped compaction Message-ID: <20140725122249.GX10819@suse.de> References: <1405518503-27687-1-git-send-email-vbabka@suse.cz> <1405518503-27687-4-git-send-email-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1405518503-27687-4-git-send-email-vbabka@suse.cz> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 16, 2014 at 03:48:11PM +0200, Vlastimil Babka wrote: > The compact_stall vmstat counter counts the number of allocations stalled by > direct compaction. It does not count when all attempted zones had deferred > compaction, but it does count when all zones skipped compaction. The skipping > is decided based on very early check of compaction_suitable(), based on > watermarks and memory fragmentation. Therefore it makes sense not to count > skipped compactions as stalls. Moreover, compact_success or compact_fail is > also already not being counted when compaction was skipped, so this patch > changes the compact_stall counting to match the other two. > > Additionally, restructure __alloc_pages_direct_compact() code for better > readability. > > Signed-off-by: Vlastimil Babka > Cc: Minchan Kim > Cc: Mel Gorman > Cc: Joonsoo Kim > Cc: Michal Nazarewicz > Cc: Naoya Horiguchi > Cc: Christoph Lameter > Cc: Rik van Riel > Cc: David Rientjes Acked-by: Mel Gorman -- Mel Gorman SUSE Labs