From: Christoph Hellwig <hch@lst.de>
To: poma <pomidorabelisima@gmail.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
Vladimir Davydov <vdavydov@parallels.com>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
Christoph Lameter <cl@linux.com>,
Mailing-List fedora-kernel <kernel@lists.fedoraproject.org>,
Paolo Bonzini <pbonzini@redhat.com>,
linux-scsi@vger.kernel.org
Subject: Re: WARNING: CPU: 1 PID: 495 at mm/slab_common.c:69 kmem_cache_create+0x1a9/0x330()
Date: Sat, 26 Jul 2014 18:21:02 +0200 [thread overview]
Message-ID: <20140726162102.GA7126@lst.de> (raw)
In-Reply-To: <53CCDFC3.5010802@gmail.com>
Here's a formal one.
James, can I get your signoff for it?
Vladimir, can I get a reviewed-by from you (or anyone else)?
---
>From 73b1034ab1418e2dea75ccf642bc85c728b57313 Mon Sep 17 00:00:00 2001
From: James Bottomley <James.Bottomley@HansenPartnership.com>
Date: Sat, 26 Jul 2014 12:21:26 -0400
Subject: scsi: use short driver name for per-driver cmd slab caches
hostt->name might contain space, so use the ->proc_name short name instead
when creating per-driver command slabs.
Reported-by: Vladimir Davydov <vdavydov@parallels.com>
Tested-by: Vladimir Davydov <vdavydov@parallels.com>
---
drivers/scsi/scsi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c
index 33318f5..df33060 100644
--- a/drivers/scsi/scsi.c
+++ b/drivers/scsi/scsi.c
@@ -365,8 +365,8 @@ scsi_alloc_host_cmd_pool(struct Scsi_Host *shost)
if (!pool)
return NULL;
- pool->cmd_name = kasprintf(GFP_KERNEL, "%s_cmd", hostt->name);
- pool->sense_name = kasprintf(GFP_KERNEL, "%s_sense", hostt->name);
+ pool->cmd_name = kasprintf(GFP_KERNEL, "%s_cmd", hostt->proc_name);
+ pool->sense_name = kasprintf(GFP_KERNEL, "%s_sense", hostt->proc_name);
if (!pool->cmd_name || !pool->sense_name) {
scsi_free_host_cmd_pool(pool);
return NULL;
--
1.9.1
next prev parent reply other threads:[~2014-07-26 16:21 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <53C8DF7F.5060707@gmail.com>
2014-07-18 10:57 ` WARNING: CPU: 1 PID: 495 at mm/slab_common.c:69 kmem_cache_create+0x1a9/0x330() poma
2014-07-18 13:21 ` Vladimir Davydov
2014-07-18 14:17 ` Christoph Hellwig
2014-07-18 20:01 ` poma
2014-07-18 20:07 ` James Bottomley
2014-07-18 20:16 ` poma
2014-07-18 21:32 ` poma
2014-07-19 16:44 ` Christoph Hellwig
2014-07-21 9:39 ` poma
2014-07-21 14:58 ` Christoph Hellwig
2014-07-21 15:38 ` poma
2014-07-26 16:21 ` Christoph Hellwig [this message]
2014-07-26 16:44 ` Martin K. Petersen
2014-07-27 8:09 ` Vladimir Davydov
2014-07-28 7:49 ` James Bottomley
2014-07-29 12:26 ` Christoph Hellwig
2014-07-29 23:25 ` poma
2014-07-30 12:21 ` Josh Boyer
2014-07-30 14:52 ` Christoph Hellwig
2014-07-30 15:04 ` James Bottomley
2014-07-30 16:15 ` Christoph Hellwig
2014-07-30 17:22 ` Mike Christie
2014-07-30 17:59 ` Christoph Hellwig
2014-07-31 13:02 ` James Bottomley
2014-07-18 14:20 ` Christoph Lameter
2014-07-18 20:03 ` poma
2014-07-18 21:35 ` poma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140726162102.GA7126@lst.de \
--to=hch@lst.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=cl@linux.com \
--cc=kernel@lists.fedoraproject.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=pomidorabelisima@gmail.com \
--cc=vdavydov@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).