public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] staging: vt6655: coding style: Fixed commenting style Few lines were crossing 80 characters limit
@ 2014-07-27 11:21 Rahul Garg
  2014-07-27 16:03 ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: Rahul Garg @ 2014-07-27 11:21 UTC (permalink / raw)
  To: gregkh; +Cc: devel, linux-kernel, Rahul Garg

Signed-off-by: Rahul Garg <rahul.lnmiit@gmail.com>
---
 drivers/staging/vt6655/tcrc.c |   11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/vt6655/tcrc.c b/drivers/staging/vt6655/tcrc.c
index ed6868a..bf8d4c3 100644
--- a/drivers/staging/vt6655/tcrc.c
+++ b/drivers/staging/vt6655/tcrc.c
@@ -41,7 +41,7 @@
 
 /*---------------------  Static Variables  --------------------------*/
 
-// 32-bit CRC table
+/* 32-bit CRC table */
 static const unsigned long s_adwCrc32Table[256] = {
 	0x00000000L, 0x77073096L, 0xEE0E612CL, 0x990951BAL,
 	0x076DC419L, 0x706AF48FL, 0xE963A535L, 0x9E6495A3L,
@@ -129,13 +129,15 @@ static const unsigned long s_adwCrc32Table[256] = {
  * Return Value: CRC-32
  *
  -*/
-unsigned long CRCdwCrc32(unsigned char *pbyData, unsigned int cbByte, unsigned long dwCrcSeed)
+unsigned long CRCdwCrc32(unsigned char *pbyData, unsigned int cbByte,
+			unsigned long dwCrcSeed)
 {
 	unsigned long dwCrc;
 
 	dwCrc = dwCrcSeed;
 	while (cbByte--) {
-		dwCrc = s_adwCrc32Table[(unsigned char)((dwCrc ^ (*pbyData)) & 0xFF)] ^ (dwCrc >> 8);
+		dwCrc = s_adwCrc32Table[(unsigned char)((dwCrc ^ (*pbyData))
+					& 0xFF)] ^ (dwCrc >> 8);
 		pbyData++;
 	}
 
@@ -185,7 +187,8 @@ unsigned long CRCdwGetCrc32(unsigned char *pbyData, unsigned int cbByte)
  * Return Value: CRC-32
  *
  -*/
-unsigned long CRCdwGetCrc32Ex(unsigned char *pbyData, unsigned int cbByte, unsigned long dwPreCRC)
+unsigned long CRCdwGetCrc32Ex(unsigned char *pbyData,
+			unsigned int cbByte, unsigned long dwPreCRC)
 {
 	return CRCdwCrc32(pbyData, cbByte, dwPreCRC);
 }
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] staging: vt6655: coding style: Fixed commenting style Few lines were crossing 80 characters limit
  2014-07-27 11:21 [PATCH] staging: vt6655: coding style: Fixed commenting style Few lines were crossing 80 characters limit Rahul Garg
@ 2014-07-27 16:03 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2014-07-27 16:03 UTC (permalink / raw)
  To: Rahul Garg; +Cc: devel, linux-kernel

On Sun, Jul 27, 2014 at 04:51:43PM +0530, Rahul Garg wrote:
> Signed-off-by: Rahul Garg <rahul.lnmiit@gmail.com>
> ---
>  drivers/staging/vt6655/tcrc.c |   11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)

I know this is a tiny patch, but you are doing two different things
here, and your subject is hugely long.

Can you break this up into 2 different patches, and provide a valid
changelog body for what you are doing?

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-07-27 16:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-27 11:21 [PATCH] staging: vt6655: coding style: Fixed commenting style Few lines were crossing 80 characters limit Rahul Garg
2014-07-27 16:03 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox