Eudyptula Challenge (Task 10)

Eudyptula Challenge (Task 10)

[Wahib Faizi]

Greetings Linux Kernel Developers!

This is Task 10 of the Eudyptula Challenge.

Eudyptula Challenge (Task 10)

[Liviu I.]

[-- Attachment #1: Type: text/plain, Size: 160 bytes --]

Hello Kernel Developers!

I've attached a small patch to fix a coding style problem and make checkpatch happy, as part of challenge 10 of Eudyptula.

Thank you

[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 444 bytes --]

--- drivers/staging/lustre/lustre/ldlm/ldlm_extent.c.orig	2014-07-27 20:26:53.714161698 +0100
+++ drivers/staging/lustre/lustre/ldlm/ldlm_extent.c	2014-07-27 20:27:50.410159692 +0100
@@ -151,7 +151,8 @@ static inline int lock_mode_to_index(ldl
 
 	LASSERT(mode != 0);
 	LASSERT(IS_PO2(mode));
-	for (index = -1; mode; index++, mode >>= 1) ;
+	for (index = -1; mode; index++, mode >>= 1)
+		;
 	LASSERT(index < LCK_MODE_NUM);
 	return index;
 }

Re: Eudyptula Challenge (Task 10)

[Greg KH]

On Sun, Jul 27, 2014 at 08:56:38PM +0100, Liviu I. wrote:
> Hello Kernel Developers!
> 
> I've attached a small patch to fix a coding style problem and make checkpatch happy, as part of challenge 10 of Eudyptula.
> 
> Thank you

> --- drivers/staging/lustre/lustre/ldlm/ldlm_extent.c.orig	2014-07-27 20:26:53.714161698 +0100
> +++ drivers/staging/lustre/lustre/ldlm/ldlm_extent.c	2014-07-27 20:27:50.410159692 +0100
> @@ -151,7 +151,8 @@ static inline int lock_mode_to_index(ldl
>  
>  	LASSERT(mode != 0);
>  	LASSERT(IS_PO2(mode));
> -	for (index = -1; mode; index++, mode >>= 1) ;
> +	for (index = -1; mode; index++, mode >>= 1)
> +		;
>  	LASSERT(index < LCK_MODE_NUM);
>  	return index;
>  }

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch does not have a Signed-off-by: line.  Please read the
  kernel file, Documentation/SubmittingPatches and resend it after
  adding that line.  Note, the line needs to be in the body of the
  email, before the patch, not at the bottom of the patch or in the
  email signature.

- You did not specify a description of why the patch is needed, or
  possibly, any description at all, in the email body.  Please read the
  section entitled "The canonical patch format" in the kernel file,
  Documentation/SubmittingPatches for what is needed in order to
  properly describe the change.

- You did not write a descriptive Subject: for the patch, allowing Greg,
  and everyone else, to know what this patch is all about.  Please read
  the section entitled "The canonical patch format" in the kernel file,
  Documentation/SubmittingPatches for what a proper Subject: line should
  look like.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

Eudyptula Challenge (Task 10)

[Liviu I.]

[-- Attachment #1: Type: text/plain, Size: 214 bytes --]

Hello Kernel Developers!

I've attached a small patch to fix a coding style problem and make checkpatch happy, as part of challenge 10 of Eudyptula.

Signed-off-by: Liviu Itoafa <liviu.i.2222@gmail.com>

Thank you

[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 444 bytes --]

--- drivers/staging/lustre/lustre/ldlm/ldlm_extent.c.orig	2014-07-27 20:26:53.714161698 +0100
+++ drivers/staging/lustre/lustre/ldlm/ldlm_extent.c	2014-07-27 20:27:50.410159692 +0100
@@ -151,7 +151,8 @@ static inline int lock_mode_to_index(ldl
 
 	LASSERT(mode != 0);
 	LASSERT(IS_PO2(mode));
-	for (index = -1; mode; index++, mode >>= 1) ;
+	for (index = -1; mode; index++, mode >>= 1)
+		;
 	LASSERT(index < LCK_MODE_NUM);
 	return index;
 }

Re: Eudyptula Challenge (Task 10)

[Dan Carpenter]

Fix your From header and read paragraph 1 of
Documentation/email-clients.txt

regards,
dan carpenter

Re: Eudyptula Challenge (Task 10)

[Christoph Hellwig]

Can you folks please stop this challenge Bullshit?  More checkpatch
fixes is not something we'll need at all.

Thanks you!

Re: Eudyptula Challenge (Task 10)

[Lucas Tanure]

Hi Christoph,

What kind of things that you think a newbie can fix ?

Thanks
--
Lucas Tanure
+55 (19) 988176559


On Mon, Jul 28, 2014 at 9:53 AM, Christoph Hellwig <hch@infradead.org> wrote:
> Can you folks please stop this challenge Bullshit?  More checkpatch
> fixes is not something we'll need at all.
>
> Thanks you!
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

Re: Eudyptula Challenge (Task 10)

[Denis Kirjanov]

On 7/28/14, Lucas Tanure <tanure@linux.com> wrote:
> Hi Christoph,
>
> What kind of things that you think a newbie can fix ?

You can start working on fixing the pci_map_* and dma_map_* return
value checks with CONFIG_DMA_API_DEBUG enabled. A lot of drivers still
missing that...

> Thanks
> --
> Lucas Tanure
> +55 (19) 988176559
>
>
> On Mon, Jul 28, 2014 at 9:53 AM, Christoph Hellwig <hch@infradead.org>
> wrote:
>> Can you folks please stop this challenge Bullshit?  More checkpatch
>> fixes is not something we'll need at all.
>>
>> Thanks you!
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel"
>> in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at  http://www.tux.org/lkml/
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
>


-- 
Regards,
Denis

Re: Eudyptula Challenge (Task 10)

[Jason Cooper]

On Mon, Jul 28, 2014 at 05:53:19AM -0700, Christoph Hellwig wrote:
> Can you folks please stop this challenge Bullshit?  More checkpatch
> fixes is not something we'll need at all.

Greg and Dan have previously said that the staging tree is a good place
for newcomers to submit checkpatch cleanup patches.  However, I think
there are a few tweaks that could be made to the Eudyptula Challenge to
avoid this noise/frustration:

  - No need to send to lkml, the staging tree ML is probably fine.

  - Don't mention Eudyptula Challenge, it's not relevant to the patch.
     * It looks like you want a cookie.  We have none.

  - Submit the patch to the Challenge admins first for review.  This
    patch submission should have never made the cut.
     - No S-o-B
     - MIME attachment
     - Subject line is just wrong
     - Full name missing in From:

I've worked with several participants of the challenge and never saw
this many things wrong with a patch submission.  Either the admins are
dropping the ball, or this participant got loose somehow. :)

It makes me wonder if they should start with a git workflow from day
one?  It would prevent a lot of these avoidable mistakes.

thx,

Jason.