From: Greg KH <gregkh@linuxfoundation.org>
To: Anil Belur <askb23@gmail.com>
Cc: daeseok.youn@gmail.com, shaun@xresource.ca,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] drivers: staging: cxt1e1: linux.c - missing __user annotation
Date: Sun, 27 Jul 2014 20:13:46 -0700 [thread overview]
Message-ID: <20140728031346.GA7585@kroah.com> (raw)
In-Reply-To: <1406516909-5338-1-git-send-email-askb23@gmail.com>
On Mon, Jul 28, 2014 at 08:38:29AM +0530, Anil Belur wrote:
> From: Anil Belur <askb23@gmail.com>
>
> - Some of the functions internally call copy_{to,from}_user() but does
> not use '__user'. this patch fixes missing __user annotations.
> - this patch fixes the following sparse errors:
> drivers/staging/cxt1e1/linux.c:488:33: warning: incorrect type in argument 2 (different address spaces)
> drivers/staging/cxt1e1/linux.c:488:33: expected void const [noderef] <asn:1>*from
> drivers/staging/cxt1e1/linux.c:488:33: got void *data
> drivers/staging/cxt1e1/linux.c:499:26: warning: incorrect type in argument 1 (different address spaces)
> drivers/staging/cxt1e1/linux.c:499:26: expected void [noderef] <asn:1>*to
> drivers/staging/cxt1e1/linux.c:499:26: got void *data
> drivers/staging/cxt1e1/linux.c:512:33: warning: incorrect type in argument 2 (different address spaces)
> drivers/staging/cxt1e1/linux.c:512:33: expected void const [noderef] <asn:1>*from
> drivers/staging/cxt1e1/linux.c:512:33: got void *data
> drivers/staging/cxt1e1/linux.c:534:33: warning: incorrect type in argument 2 (different address spaces)
> drivers/staging/cxt1e1/linux.c:534:33: expected void const [noderef] <asn:1>*from
> drivers/staging/cxt1e1/linux.c:534:33: got void *data
> drivers/staging/cxt1e1/linux.c:550:33: warning: incorrect type in argument 2 (different address spaces)
> drivers/staging/cxt1e1/linux.c:550:33: expected void const [noderef] <asn:1>*from
> drivers/staging/cxt1e1/linux.c:550:33: got void *data
> drivers/staging/cxt1e1/linux.c:558:26: warning: incorrect type in argument 1 (different address spaces)
> drivers/staging/cxt1e1/linux.c:558:26: expected void [noderef] <asn:1>*to
> drivers/staging/cxt1e1/linux.c:558:26: got void *data
> drivers/staging/cxt1e1/linux.c:571:33: warning: incorrect type in argument 2 (different address spaces)
> drivers/staging/cxt1e1/linux.c:571:33: expected void const [noderef] <asn:1>*from
> drivers/staging/cxt1e1/linux.c:571:33: got void *data
> drivers/staging/cxt1e1/linux.c:580:26: warning: incorrect type in argument 1 (different address spaces)
> drivers/staging/cxt1e1/linux.c:580:26: expected void [noderef] <asn:1>*to
> drivers/staging/cxt1e1/linux.c:580:26: got void *data
> drivers/staging/cxt1e1/linux.c:593:33: warning: incorrect type in argument 2 (different address spaces)
> drivers/staging/cxt1e1/linux.c:593:33: expected void const [noderef] <asn:1>*from
> drivers/staging/cxt1e1/linux.c:593:33: got void *data
> drivers/staging/cxt1e1/linux.c:601:26: warning: incorrect type in argument 1 (different address spaces)
> drivers/staging/cxt1e1/linux.c:601:26: expected void [noderef] <asn:1>*to
> drivers/staging/cxt1e1/linux.c:601:26: got void *data
> drivers/staging/cxt1e1/linux.c:612:33: warning: incorrect type in argument 2 (different address spaces)
> drivers/staging/cxt1e1/linux.c:612:33: expected void const [noderef] <asn:1>*from
> drivers/staging/cxt1e1/linux.c:612:33: got void *data
> drivers/staging/cxt1e1/linux.c:620:26: warning: incorrect type in argument 1 (different address spaces)
> drivers/staging/cxt1e1/linux.c:620:26: expected void [noderef] <asn:1>*to
> drivers/staging/cxt1e1/linux.c:620:26: got void *data
> drivers/staging/cxt1e1/linux.c:631:33: warning: incorrect type in argument 2 (different address spaces)
> drivers/staging/cxt1e1/linux.c:631:33: expected void const [noderef] <asn:1>*from
> drivers/staging/cxt1e1/linux.c:631:33: got void *data
> drivers/staging/cxt1e1/linux.c:647:33: warning: incorrect type in argument 2 (different address spaces)
> drivers/staging/cxt1e1/linux.c:647:33: expected void const [noderef] <asn:1>*from
> drivers/staging/cxt1e1/linux.c:647:33: got void *data
> drivers/staging/cxt1e1/linux.c:673:34: warning: incorrect type in argument 2 (different address spaces)
> drivers/staging/cxt1e1/linux.c:673:34: expected void const [noderef] <asn:1>*from
> drivers/staging/cxt1e1/linux.c:673:34: got void *data
> drivers/staging/cxt1e1/linux.c:681:26: warning: incorrect type in argument 1 (different address spaces)
> drivers/staging/cxt1e1/linux.c:681:26: expected void [noderef] <asn:1>*to
> drivers/staging/cxt1e1/linux.c:681:26: got void *data
> drivers/staging/cxt1e1/linux.c:691:47: warning: incorrect type in argument 2 (different address spaces)
> drivers/staging/cxt1e1/linux.c:691:47: expected void const [noderef] <asn:1>*from
> drivers/staging/cxt1e1/linux.c:691:47: got void *data
> drivers/staging/cxt1e1/linux.c:738:33: warning: incorrect type in argument 2 (different address spaces)
> drivers/staging/cxt1e1/linux.c:738:33: expected void const [noderef] <asn:1>*from
> drivers/staging/cxt1e1/linux.c:738:33: got void *data
> drivers/staging/cxt1e1/linux.c:785:33: warning: incorrect type in argument 2 (different address spaces)
> drivers/staging/cxt1e1/linux.c:785:33: expected void const [noderef] <asn:1>*from
> drivers/staging/cxt1e1/linux.c:785:33: got void *data
> drivers/staging/cxt1e1/linux.c:839:14: warning: incorrect type in assignment (different address spaces)
> drivers/staging/cxt1e1/linux.c:839:14: expected void *data
> drivers/staging/cxt1e1/linux.c:839:14: got void [noderef] <asn:1>*
> drivers/staging/cxt1e1/linux.c:840:34: warning: incorrect type in argument 2 (different address spaces)
> drivers/staging/cxt1e1/linux.c:840:34: expected void const [noderef] <asn:1>*from
> drivers/staging/cxt1e1/linux.c:840:34: got void *data
> drivers/staging/cxt1e1/linux.c:891:42: warning: incorrect type in argument 1 (different address spaces)
> drivers/staging/cxt1e1/linux.c:891:42: expected void [noderef] <asn:1>*to
> drivers/staging/cxt1e1/linux.c:891:42: got void *data
>
> Signed-off-by: Anil Belur <askb23@gmail.com>
> ---
> drivers/staging/cxt1e1/linux.c | 30 +++++++++++++++---------------
> 1 file changed, 15 insertions(+), 15 deletions(-)
This file is no longer in my tree, or in linux-next :(
prev parent reply other threads:[~2014-07-28 3:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-28 3:08 [PATCH 1/1] drivers: staging: cxt1e1: linux.c - missing __user annotation Anil Belur
2014-07-28 3:13 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140728031346.GA7585@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=askb23@gmail.com \
--cc=daeseok.youn@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shaun@xresource.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox