public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Yuyang Du <yuyang.du@intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: bsegall@google.com, mingo@redhat.com,
	linux-kernel@vger.kernel.org, pjt@google.com,
	arjan.van.de.ven@intel.com, len.brown@intel.com,
	rafael.j.wysocki@intel.com, alan.cox@intel.com,
	mark.gross@intel.com, fengguang.wu@intel.com
Subject: Re: [PATCH 2/2 v4] sched: Rewrite per entity runnable load average tracking
Date: Tue, 29 Jul 2014 09:13:42 +0800	[thread overview]
Message-ID: <20140729011342.GC5203@intel.com> (raw)
In-Reply-To: <20140728171909.GW19379@twins.programming.kicks-ass.net>

On Mon, Jul 28, 2014 at 07:19:09PM +0200, Peter Zijlstra wrote:
> > > And here we try and make good on that assumption. The thing I worry
> > > about is what happens if the machine is entirely idle...
> > >
> > > What guarantees an semi up-to-date cfs_rq->avg.last_update_time.
> > 
> > update_blocked_averages I think should do just as good a job as the old
> > code, which isn't perfect but is about as good as you can get worst case.
> 
> Right, that's called from rebalance_domains() which should more or less
> update this value on tick boundaries or thereabouts for most 'active'
> cpus.
> 
> But if the entire machine is idle, the first wakeup (if its a x-cpu one)
> might see a very stale timestamp.
> 
> If we can fix that, that would be good I suppose, but I'm not
> immediately seeing something pretty there, but you're right, it'd not be
> worse than the current situation.

It matters time is up-to-date before load_avg is actually used. So yes, we should
have already achieved that.

  reply	other threads:[~2014-07-29  9:16 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-17 23:26 [PATCH 0/2 v4] sched: Rewrite per entity runnable load average tracking Yuyang Du
2014-07-17 23:26 ` [PATCH 1/2 v4] sched: Remove update_rq_runnable_avg Yuyang Du
2014-07-17 23:26 ` [PATCH 2/2 v4] sched: Rewrite per entity runnable load average tracking Yuyang Du
2014-07-18  9:43   ` Vincent Guittot
2014-07-27 17:36     ` Yuyang Du
2014-07-29  9:12       ` Vincent Guittot
2014-07-29  1:43         ` Yuyang Du
2014-07-29 13:17           ` Vincent Guittot
2014-07-29 22:27             ` Yuyang Du
2014-07-30  8:30               ` Peter Zijlstra
2014-07-30  0:40                 ` Yuyang Du
2014-07-29  9:39         ` Peter Zijlstra
2014-07-29  1:53           ` Yuyang Du
2014-07-29 13:35             ` Peter Zijlstra
2014-07-29 15:55               ` Peter Zijlstra
2014-07-29 23:08               ` Yuyang Du
2014-07-31  9:40             ` Vincent Guittot
2014-07-31  9:56             ` [PATCH 2/2 v4] sched: Rewrite per entity runnable load average Vincent Guittot
2014-07-31 19:16               ` Yuyang Du
2014-08-01  9:28                 ` Vincent Guittot
2014-07-28 10:48   ` [PATCH 2/2 v4] sched: Rewrite per entity runnable load average tracking Peter Zijlstra
2014-07-29  0:56     ` Yuyang Du
2014-07-29 13:15       ` Peter Zijlstra
2014-07-28 11:39   ` Peter Zijlstra
2014-07-29  1:09     ` Yuyang Du
2014-07-29 13:19       ` Peter Zijlstra
2014-07-28 12:01   ` Peter Zijlstra
2014-07-28 13:51   ` Peter Zijlstra
2014-07-28 16:58     ` bsegall
2014-07-28 17:19       ` Peter Zijlstra
2014-07-29  1:13         ` Yuyang Du [this message]
2014-07-18 15:39 ` [PATCH 0/2 " Morten Rasmussen
2014-07-27 19:02   ` Yuyang Du
2014-07-28 10:38     ` Peter Zijlstra
2014-07-29  1:17       ` Yuyang Du
2014-07-29 13:06         ` Peter Zijlstra
2014-07-30 10:13     ` Morten Rasmussen
2014-07-30 10:21       ` Peter Zijlstra
2014-07-30 10:57         ` Morten Rasmussen
2014-07-30 19:17       ` Yuyang Du
2014-07-31  8:54         ` Morten Rasmussen
2014-07-31  2:15           ` Yuyang Du
2014-07-20  5:46 ` Mike Galbraith
2014-07-27 19:34   ` Yuyang Du
2014-07-28  7:49     ` Mike Galbraith
2014-07-28  0:01       ` Yuyang Du
2014-07-28  8:55     ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140729011342.GC5203@intel.com \
    --to=yuyang.du@intel.com \
    --cc=alan.cox@intel.com \
    --cc=arjan.van.de.ven@intel.com \
    --cc=bsegall@google.com \
    --cc=fengguang.wu@intel.com \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.gross@intel.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=pjt@google.com \
    --cc=rafael.j.wysocki@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox